Summary: | new-run-webkit-tests: fix http server startup/shutdown | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dirk Pranke <dpranke> | ||||||
Component: | New Bugs | Assignee: | Dirk Pranke <dpranke> | ||||||
Status: | RESOLVED WONTFIX | ||||||||
Severity: | Normal | CC: | abarth, aroben, eric, ojan, tony | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Other | ||||||||
OS: | OS X 10.5 | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 59985, 59993 | ||||||||
Attachments: |
|
Description
Dirk Pranke
2011-05-02 16:29:58 PDT
Created attachment 92004 [details]
Patch
Created attachment 92005 [details]
Patch
*** Bug 50596 has been marked as a duplicate of this bug. *** Comment on attachment 92005 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=92005&action=review > Tools/Scripts/webkitpy/layout_tests/port/http_server_base.py:72 > + _log.debug("Server isn't running at all") Maybe something like "Server process could not be started."? This patch is fine, but it's on the large side. Seems like the three fixes you mention in the ChangeLog could have been three separate patches (or maybe two patches since fix 1 & 2 are relatively small). Committed r85659: <http://trac.webkit.org/changeset/85659> Reverted r85659 for reason: restarting isn't working correctly Committed r85665: <http://trac.webkit.org/changeset/85665> I'm going to split this up into smaller changes and re-land them individually to simplify things. Closing. |