Bug 59977

Summary: new-run-webkit-tests: fix http server startup/shutdown
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: New BugsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED WONTFIX    
Severity: Normal CC: abarth, aroben, eric, ojan, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 59985, 59993    
Attachments:
Description Flags
Patch
none
Patch ojan: review+

Dirk Pranke
Reported 2011-05-02 16:29:58 PDT
new-run-webkit-tests: fix http server startup/shutdown
Attachments
Patch (17.34 KB, patch)
2011-05-02 16:53 PDT, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
Patch (17.33 KB, patch)
2011-05-02 16:55 PDT, Dirk Pranke 		ojan: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2011-05-02 16:53:50 PDT
Created attachment 92004 [details] Patch
Dirk Pranke
Comment 2 2011-05-02 16:55:44 PDT
Created attachment 92005 [details] Patch
Dirk Pranke
Comment 3 2011-05-02 18:12:51 PDT
*** Bug 50596 has been marked as a duplicate of this bug. ***
Ojan Vafai
Comment 4 2011-05-02 18:40:49 PDT
Comment on attachment 92005 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=92005&action=review > Tools/Scripts/webkitpy/layout_tests/port/http_server_base.py:72 > + _log.debug("Server isn't running at all") Maybe something like "Server process could not be started."?
Tony Chang
Comment 5 2011-05-03 09:50:37 PDT
This patch is fine, but it's on the large side. Seems like the three fixes you mention in the ChangeLog could have been three separate patches (or maybe two patches since fix 1 & 2 are relatively small).
Dirk Pranke
Comment 6 2011-05-03 14:18:51 PDT
Committed r85659: <http://trac.webkit.org/changeset/85659>
Dirk Pranke
Comment 7 2011-05-03 14:51:42 PDT
Reverted r85659 for reason: restarting isn't working correctly Committed r85665: <http://trac.webkit.org/changeset/85665>
Dirk Pranke
Comment 8 2011-06-06 15:32:26 PDT
I'm going to split this up into smaller changes and re-land them individually to simplify things. Closing.
Note You need to log in before you can comment on or make changes to this bug.