Bug 59909

Summary: Remove obsolete LOOSE_OWN_PTR code
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: Web Template FrameworkAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, darin, dglazkov, gustavo.noronha, gustavo, webkit-ews, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on: 59428    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Patrick R. Gansterer
Reported 2011-05-01 18:24:31 PDT
Remove obsolete LOOSE_OWN_PTR code
Attachments
Patch (1.54 KB, patch)
2011-05-01 18:25 PDT, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Patch (6.45 KB, patch)
2011-06-15 12:38 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (8.86 KB, patch)
2011-06-15 12:43 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2011-05-01 18:25:21 PDT
Created attachment 91868 [details] Patch
Adam Barth
Comment 2 2011-05-01 18:37:46 PDT
Comment on attachment 91868 [details] Patch This is still used in a couple files that were tricky to fix. Also, Darin asked that we leave this code around for a bit presumably because some code inside Apple needs to be updated.
Early Warning System Bot
Comment 3 2011-05-01 18:46:07 PDT
Attachment 91868 [details] did not build on qt: Build output: http://queues.webkit.org/results/8530490
WebKit Review Bot
Comment 4 2011-05-01 19:48:05 PDT
Attachment 91868 [details] did not build on chromium: Build output: http://queues.webkit.org/results/8531524
WebKit Review Bot
Comment 5 2011-05-01 21:47:38 PDT
Attachment 91868 [details] did not build on mac: Build output: http://queues.webkit.org/results/8531540
WebKit Review Bot
Comment 6 2011-05-01 22:27:54 PDT
Attachment 91868 [details] did not build on chromium: Build output: http://queues.webkit.org/results/8529521
WebKit Review Bot
Comment 7 2011-05-01 22:49:19 PDT
Attachment 91868 [details] did not build on mac: Build output: http://queues.webkit.org/results/8530543
Build Bot
Comment 8 2011-05-01 23:17:27 PDT
Attachment 91868 [details] did not build on win: Build output: http://queues.webkit.org/results/8530555
Collabora GTK+ EWS bot
Comment 9 2011-05-01 23:23:51 PDT
Attachment 91868 [details] did not build on gtk: Build output: http://queues.webkit.org/results/8532106
WebKit Review Bot
Comment 10 2011-05-01 23:33:44 PDT
Attachment 91868 [details] did not build on chromium: Build output: http://queues.webkit.org/results/8525810
Darin Adler
Comment 11 2011-06-15 12:38:24 PDT
Created attachment 97345 [details] Patch
Darin Adler
Comment 12 2011-06-15 12:38:43 PDT
*** Bug 60670 has been marked as a duplicate of this bug. ***
Darin Adler
Comment 13 2011-06-15 12:40:17 PDT
Comment on attachment 97345 [details] Patch Oops, looks like this will break Chromium, which still has two files depending on LOOSE_OWN_PTR.
Darin Adler
Comment 14 2011-06-15 12:43:45 PDT
Created attachment 97346 [details] Patch
Adam Barth
Comment 15 2011-06-15 14:28:39 PDT
Comment on attachment 97346 [details] Patch Yay. Darin, you're my hero.
Darin Adler
Comment 16 2011-06-15 18:17:49 PDT
Comment on attachment 97346 [details] Patch Clearing flags on attachment: 97346 Committed r88988: <http://trac.webkit.org/changeset/88988>
Darin Adler
Comment 17 2011-06-15 18:17:54 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.