Bug 59659

Summary:

Make GraphicsContext3DChromium play nice with strict OwnPtrs

Product:

WebKit

Reporter:

Adam Barth <abarth>

Component:

New Bugs

Assignee:

Adam Barth <abarth>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

kbr, levin

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Bug Depends on:

59434, 59459, 59487

Bug Blocks:

Attachments:

Description	Flags
Patch	levin: review+

Adam Barth

Reported 2011-04-27 16:56:18 PDT

Make GraphicsContext3DChromium play nice with strict OwnPtrs

Attachments
Patch (1.98 KB, patch) 2011-04-27 16:56 PDT, Adam Barth	levin: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Adam Barth

Comment 1 2011-04-27 16:56:57 PDT

Created attachment 91385 [details] Patch

David Levin

Comment 2 2011-04-27 17:06:25 PDT

Comment on attachment 91385 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=91385&action=review > Source/WebKit/chromium/src/GraphicsContext3DChromium.cpp:112 > + OwnPtr<WebKit::WebGraphicsContext3D> webContext = adoptPtr(WebKit::webKitClient()->createGraphicsContext3D()); Since it is part of webKitClient we can't change it to return PassOwnPtr?

Adam Barth

Comment 3 2011-04-27 17:14:49 PDT

Comment on attachment 91385 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=91385&action=review >> Source/WebKit/chromium/src/GraphicsContext3DChromium.cpp:112 >> - WebKit::WebGraphicsContext3D* webContext = WebKit::webKitClient()->createGraphicsContext3D(); >> + OwnPtr<WebKit::WebGraphicsContext3D> webContext = adoptPtr(WebKit::webKitClient()->createGraphicsContext3D()); > > Since it is part of webKitClient we can't change it to return PassOwnPtr? I don't think we can use PassOwnPtr in WebKitClient.h. That code needs to be free of WebCore types.

Adam Barth

Comment 4 2011-04-27 17:17:35 PDT

Committed r85126: <http://trac.webkit.org/changeset/85126>

Note You need to log in before you can comment on or make changes to this bug.