Bug 59487

Summary: OwnPtr assignment operator should be private
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, darin, eric, jamesr, kbr, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 59459, 59659    
Attachments:
Description Flags
Patch none

Adam Barth
Reported 2011-04-26 13:49:16 PDT
OwnPtr assignment operator should be private
Attachments
Patch (1.02 KB, patch)
2011-04-26 13:50 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2011-04-26 13:50:42 PDT
Created attachment 91150 [details] Patch
Kenneth Russell
Comment 2 2011-04-26 14:05:36 PDT
Comment on attachment 91150 [details] Patch This is important to fix as it allowed https://bugs.webkit.org/show_bug.cgi?id=59459 to creep in during the strict OwnPtr cleanup yesterday. I wonder whether it's worth a comment directly above the new private assignment operator indicating why it's necessary. Looks good to me otherwise.
WebKit Commit Bot
Comment 3 2011-04-27 00:14:16 PDT
The commit-queue encountered the following flaky tests while processing attachment 91150 [details]: java/lc3/JSObject/ToObject-001.html bug 53091 (author: ap@webkit.org) http/tests/xmlhttprequest/basic-auth.html bug 51613 (author: ap@webkit.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 4 2011-04-27 00:15:58 PDT
Comment on attachment 91150 [details] Patch Clearing flags on attachment: 91150 Committed r85028: <http://trac.webkit.org/changeset/85028>
WebKit Commit Bot
Comment 5 2011-04-27 00:16:04 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 6 2011-04-27 01:01:50 PDT
http://trac.webkit.org/changeset/85028 might have broken Chromium Win Release
Note You need to log in before you can comment on or make changes to this bug.