| Summary: | OwnPtr assignment operator should be private | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||
| Component: | New Bugs | Assignee: | Adam Barth <abarth> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, commit-queue, darin, eric, jamesr, kbr, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Other | ||||||
| OS: | OS X 10.5 | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 59459, 59659 | ||||||
| Attachments: |
|
||||||
|
Description
Adam Barth
2011-04-26 13:49:16 PDT
Created attachment 91150 [details]
Patch
Comment on attachment 91150 [details] Patch This is important to fix as it allowed https://bugs.webkit.org/show_bug.cgi?id=59459 to creep in during the strict OwnPtr cleanup yesterday. I wonder whether it's worth a comment directly above the new private assignment operator indicating why it's necessary. Looks good to me otherwise. The commit-queue encountered the following flaky tests while processing attachment 91150 [details]: java/lc3/JSObject/ToObject-001.html bug 53091 (author: ap@webkit.org) http/tests/xmlhttprequest/basic-auth.html bug 51613 (author: ap@webkit.org) The commit-queue is continuing to process your patch. Comment on attachment 91150 [details] Patch Clearing flags on attachment: 91150 Committed r85028: <http://trac.webkit.org/changeset/85028> All reviewed patches have been landed. Closing bug. http://trac.webkit.org/changeset/85028 might have broken Chromium Win Release |