Bug 59081
| Summary: | Windows DRT needs an implementation of shadowRoot | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Yuta Kitamura <yutak> |
| Component: | Tools / Tests | Assignee: | Dominic Cooney <dominicc> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | dominicc, jberlin, rolandsteiner |
| Priority: | P2 | Keywords: | LayoutTestFailure, PlatformOnly |
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | Windows 7 | ||
| Bug Depends on: | 61671 | ||
| Bug Blocks: | |||
Yuta Kitamura
Since r84472 (bug 59058), fast/dom/shadow/layout-tests-can-access-shadow.html is failing on Windows.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Yuta Kitamura
Committed r84476: <http://trac.webkit.org/changeset/84476>
Yuta Kitamura
Ooh, it's not fixed yet :) Fixing the status.
Yuta Kitamura
Test results (http://build.webkit.org/results/Windows%20XP%20Debug%20(Tests)/r84472%20(27888)/fast/dom/shadow/layout-tests-can-access-shadow-diffs.txt)
--- /home/buildbot/slave/win-debug-tests/build/layout-test-results/fast/dom/shadow/layout-tests-can-access-shadow-expected.txt 2011-04-21 23:56:11.531250000 -0700
+++ /home/buildbot/slave/win-debug-tests/build/layout-test-results/fast/dom/shadow/layout-tests-can-access-shadow-actual.txt 2011-04-21 23:56:11.531250000 -0700
@@ -1,12 +1,12 @@
This tests that LayoutTestController can access shadow DOM.
-PASS shadow.nodeName is "#shadow-root"
-PASS layoutTestController.shadowRoot(shadow) is null
-PASS layoutTestController.shadowRoot(p) is null
-PASS shadow.nodeName is "#shadow-root"
+FAIL shadow.nodeName should be #shadow-root. Threw exception TypeError: 'undefined' is not an object (evaluating 'shadow.nodeName')
+FAIL layoutTestController.shadowRoot(shadow) should be null (of type object). Was undefined (of type undefined).
+FAIL layoutTestController.shadowRoot(p) should be null (of type object). Was undefined (of type undefined).
+FAIL shadow.nodeName should be #shadow-root. Threw exception TypeError: 'undefined' is not an object (evaluating 'shadow.nodeName')
PASS shadow === layoutTestController.shadowRoot(p) is true
-PASS layoutTestController.shadowRoot(keygen) is null
+FAIL layoutTestController.shadowRoot(keygen) should be null (of type object). Was undefined (of type undefined).
PASS successfullyParsed is true
TEST COMPLETE
Roland Steiner
Same goes for fast/dom/shadow/nodetype.html
Roland Steiner
Committed r84533: <http://trac.webkit.org/changeset/84533>
Philippe Normand
Skipped media/video-controls-visible-audio-only.html too as a consequence of ttp://trac.webkit.org/changeset/85934
Dominic Cooney
It does not make sense to implement layoutTestController.shadowRoot/ensureShadowRoot/removeShadowRoot/shadowPseudoId, because those methods are moving to window.internals per bug 61671. So the win DRT implementation of shadowRoot and friends is blocked on that.
Dominic Cooney
Fixed in r89682. Windows tests can use internals.shadowRoot, ensureShadowRoot, shadowPseudoId, etc. and the mentioned tests were unskipped in that revision.