Bug 59055

Summary:

Content of <details> should be forwarded through the shadow DOM

Product:

WebKit

Reporter:

Hajime Morrita <morrita>

Component:

DOM

Assignee:

Hajime Morrita <morrita>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, dglazkov, eric, luiz, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Bug Depends on:

Bug Blocks:

56967, 56973

Attachments:

Description	Flags
Patch	dglazkov: review+

Hajime Morrita

Reported 2011-04-20 18:10:31 PDT

Twin brother of 58914.

Attachments
Patch (175.85 KB, patch) 2011-04-21 18:13 PDT, Hajime Morrita	dglazkov: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Hajime Morrita

Comment 1 2011-04-21 18:13:14 PDT

Created attachment 90646 [details] Patch

Hajime Morrita

Comment 2 2011-04-21 18:15:10 PDT

Dimitri, I finally found that we need RenderObject gathering/redistribution for <content> due to the reason mentioned at Bug 59157. But I'd like to do it at the separate patch to keep this change simple and safe.

Dimitri Glazkov (Google)

Comment 3 2011-04-21 20:45:05 PDT

Comment on attachment 90646 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=90646&action=review > Source/WebCore/dom/ShadowRoot.cpp:33 > +// This dependency might look strange. But it should be sane. See https://bugs.webkit.org/show_bug.cgi?id=59117 No need for this comment, we'll fix it soon. > Source/WebCore/rendering/RenderDetails.cpp:37 > +// This should be removed. See https://bugs.webkit.org/show_bug.cgi?id=59157 FIXME:

Hajime Morrita

Comment 4 2011-04-22 09:13:35 PDT

Committed r84632: <http://trac.webkit.org/changeset/84632>

WebKit Review Bot

Comment 5 2011-04-22 09:49:03 PDT

http://trac.webkit.org/changeset/84632 might have broken Qt Linux Release The following tests are not passing: fast/html/details-add-summary-1-and-click.html fast/html/details-add-summary-1.html fast/html/details-add-summary-10-and-click.html fast/html/details-add-summary-10.html fast/html/details-add-summary-2-and-click.html fast/html/details-add-summary-2.html fast/html/details-add-summary-3-and-click.html fast/html/details-add-summary-3.html fast/html/details-add-summary-4-and-click.html fast/html/details-add-summary-4.html fast/html/details-add-summary-5-and-click.html fast/html/details-add-summary-5.html fast/html/details-add-summary-6-and-click.html fast/html/details-add-summary-6.html fast/html/details-add-summary-7-and-click.html fast/html/details-add-summary-7.html fast/html/details-add-summary-8-and-click.html fast/html/details-add-summary-8.html fast/html/details-add-summary-9-and-click.html fast/html/details-add-summary-9.html fast/html/details-no-summary1.html fast/html/details-no-summary2.html fast/html/details-no-summary3.html fast/html/details-no-summary4.html fast/html/details-open-javascript.html fast/html/details-open1.html fast/html/details-open2.html fast/html/details-open3.html fast/html/details-open4.html fast/html/details-open5.html fast/html/details-open6.html fast/html/details-position.html fast/html/details-remove-summary-1-and-click.html fast/html/details-remove-summary-1.html fast/html/details-remove-summary-2-and-click.html fast/html/details-remove-summary-2.html fast/html/details-remove-summary-3-and-click.html fast/html/details-remove-summary-3.html fast/html/details-remove-summary-4-and-click.html fast/html/details-remove-summary-4.html fast/html/details-remove-summary-5-and-click.html fast/html/details-remove-summary-5.html fast/html/details-remove-summary-6-and-click.html fast/html/details-remove-summary-6.html fast/html/details-writing-mode.html

Note You need to log in before you can comment on or make changes to this bug.