Bug 59055 – Content of <details> should be forwarded through the shadow DOM

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Hajime Morrita]

Twin brother of 58914.

[Hajime Morrita]

Created attachment 90646 [details]
Patch

[Hajime Morrita]

Dimitri, 
I finally found that we need RenderObject gathering/redistribution for <content> 
due to the reason mentioned at Bug 59157.
But I'd like to do it at the separate patch to keep this change simple and safe.

[Dimitri Glazkov (Google)]

Comment on attachment 90646 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=90646&action=review

> Source/WebCore/dom/ShadowRoot.cpp:33
> +// This dependency might look strange. But it should be sane. See https://bugs.webkit.org/show_bug.cgi?id=59117

No need for this comment, we'll fix it soon.

> Source/WebCore/rendering/RenderDetails.cpp:37
> +// This should be removed. See https://bugs.webkit.org/show_bug.cgi?id=59157

FIXME:

[Hajime Morrita]

Committed r84632: <http://trac.webkit.org/changeset/84632>

[WebKit Review Bot]

http://trac.webkit.org/changeset/84632 might have broken Qt Linux Release
The following tests are not passing:
fast/html/details-add-summary-1-and-click.html
fast/html/details-add-summary-1.html
fast/html/details-add-summary-10-and-click.html
fast/html/details-add-summary-10.html
fast/html/details-add-summary-2-and-click.html
fast/html/details-add-summary-2.html
fast/html/details-add-summary-3-and-click.html
fast/html/details-add-summary-3.html
fast/html/details-add-summary-4-and-click.html
fast/html/details-add-summary-4.html
fast/html/details-add-summary-5-and-click.html
fast/html/details-add-summary-5.html
fast/html/details-add-summary-6-and-click.html
fast/html/details-add-summary-6.html
fast/html/details-add-summary-7-and-click.html
fast/html/details-add-summary-7.html
fast/html/details-add-summary-8-and-click.html
fast/html/details-add-summary-8.html
fast/html/details-add-summary-9-and-click.html
fast/html/details-add-summary-9.html
fast/html/details-no-summary1.html
fast/html/details-no-summary2.html
fast/html/details-no-summary3.html
fast/html/details-no-summary4.html
fast/html/details-open-javascript.html
fast/html/details-open1.html
fast/html/details-open2.html
fast/html/details-open3.html
fast/html/details-open4.html
fast/html/details-open5.html
fast/html/details-open6.html
fast/html/details-position.html
fast/html/details-remove-summary-1-and-click.html
fast/html/details-remove-summary-1.html
fast/html/details-remove-summary-2-and-click.html
fast/html/details-remove-summary-2.html
fast/html/details-remove-summary-3-and-click.html
fast/html/details-remove-summary-3.html
fast/html/details-remove-summary-4-and-click.html
fast/html/details-remove-summary-4.html
fast/html/details-remove-summary-5-and-click.html
fast/html/details-remove-summary-5.html
fast/html/details-remove-summary-6-and-click.html
fast/html/details-remove-summary-6.html
fast/html/details-writing-mode.html