Bug 59117 - [Refactoring] ShadowContentElement should be part of dom/
Summary: [Refactoring] ShadowContentElement should be part of dom/
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Hajime Morrita
URL:
Keywords:
Depends on:
Blocks: 56973
  Show dependency tree / graph
 
Reported: 2011-04-21 10:55 PDT by Hajime Morrita
Modified: 2011-05-17 18:48 PDT (History)
5 users (show)

See Also:

Attachments
Patch (25.31 KB, patch)
2011-05-16 03:48 PDT, Hajime Morrita 		dglazkov: review-
webkit-ews: commit-queue-
Details | Formatted Diff | Diff
A patch made by git diff (37.38 KB, patch)
2011-05-16 19:21 PDT, Hajime Morrita 		no flags Details | Formatted Diff | Diff
Trying to fix windows build (37.96 KB, patch)
2011-05-16 22:11 PDT, Hajime Morrita 		dglazkov: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hajime Morrita 2011-04-21 10:55:19 PDT 
Currently it's under html/shadow/, but it should be under dom/ because ShadowRoot is going to work with it.
Comment 1 Hajime Morrita 2011-05-16 03:48:27 PDT 
Created attachment 93632 [details]
Patch
Comment 2 Early Warning System Bot 2011-05-16 04:08:23 PDT 
Comment on attachment 93632 [details]
Patch

Attachment 93632 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/8700785
Comment 3 Gyuyoung Kim 2011-05-16 04:14:41 PDT 
Comment on attachment 93632 [details]
Patch

Attachment 93632 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/8699830
Comment 4 Collabora GTK+ EWS bot 2011-05-16 04:23:45 PDT 
Comment on attachment 93632 [details]
Patch

Attachment 93632 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/8695961
Comment 5 WebKit Review Bot 2011-05-16 04:28:05 PDT 
Comment on attachment 93632 [details]
Patch

Attachment 93632 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/8702038
Comment 6 WebKit Review Bot 2011-05-16 05:34:23 PDT 
Comment on attachment 93632 [details]
Patch

Attachment 93632 [details] did not pass cr-mac-ews (chromium):
Output: http://queues.webkit.org/results/8694992
Comment 7 WebKit Review Bot 2011-05-16 06:06:32 PDT 
Comment on attachment 93632 [details]
Patch

Attachment 93632 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/8701726
Comment 8 WebKit Review Bot 2011-05-16 06:41:05 PDT 
Comment on attachment 93632 [details]
Patch

Attachment 93632 [details] did not pass cr-mac-ews (chromium):
Output: http://queues.webkit.org/results/8695986
Comment 9 Dimitri Glazkov (Google) 2011-05-16 08:38:40 PDT 
Comment on attachment 93632 [details]
Patch

Angry mob of bots are forcing me to r- this patch.
Comment 10 Hajime Morrita 2011-05-16 18:20:37 PDT 
Hmm. The file renaming seems failed - they saw old ShadowContentElement.h.
Comment 11 Hajime Morrita 2011-05-16 18:27:33 PDT 
(In reply to comment #10)
> Hmm. The file renaming seems failed - they saw old ShadowContentElement.h.
No, the patch was wrong....
Comment 12 Hajime Morrita 2011-05-16 19:21:14 PDT 
Created attachment 93729 [details]
A patch made by git diff

Manually attaching the patch.
Comment 13 Hajime Morrita 2011-05-16 22:11:39 PDT 
Created attachment 93737 [details]
Trying to fix windows build
Comment 14 Dimitri Glazkov (Google) 2011-05-17 09:01:00 PDT 
Comment on attachment 93737 [details]
Trying to fix windows build

View in context: https://bugs.webkit.org/attachment.cgi?id=93737&action=review

> Source/WebCore/dom/Node.h:737
> +inline void Node::forceReattach()

It would be a great clean up patch for someone to go and replace all attach/detach uses with this.
Comment 15 Hajime Morrita 2011-05-17 18:19:00 PDT 
> It would be a great clean up patch for someone to go and replace all attach/detach uses with this.
Feeling same, filed Bug 61011.
Comment 16 Hajime Morrita 2011-05-17 18:48:56 PDT 
Committed r86726: <http://trac.webkit.org/changeset/86726>