Bug 58704

Summary: Decide on node type for ShadowRoot
Product: WebKit Reporter: Roland Steiner <rolandsteiner>
Component: DOMAssignee: Roland Steiner <rolandsteiner>
Severity: Normal CC: abarth, ap, dglazkov, dominicc, eric, morrita, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 48698, 54179    
Description Flags
patch, cleanup, added WebKit parts dglazkov: review+

Description Roland Steiner 2011-04-15 15:39:41 PDT
ShadowRoot currently returns a placeholder DOCUMENT_FRAGMENT_NODE as node type.

We need to decide whether to keep that, or whether to introduce a new node type.
Comment 1 Dimitri Glazkov (Google) 2011-04-19 09:23:19 PDT
Let's just call it SHADOW_ROOT.
Comment 2 Roland Steiner 2011-04-19 13:12:56 PDT
That sounds straightforward. As it so happens, I already have a stashed CL with that exact name... :)

Just need to re-land the ShadowRoot patch first.
Comment 3 Dominic Cooney 2011-04-20 11:29:47 PDT
Would we expose this to JavaScript as a constant on Node? Node.SHADOW_ROOT_NODE?
Comment 4 Roland Steiner 2011-04-20 14:43:05 PDT
Good question - I intended not to, to minimize user-visible changes, but perhaps we have to (for inspector, for example)?
Comment 5 Dimitri Glazkov (Google) 2011-04-20 15:26:11 PDT
At this point, let's not worry about JS constants.
Comment 6 Roland Steiner 2011-04-20 17:32:10 PDT
Created attachment 90456 [details]
Comment 7 Dimitri Glazkov (Google) 2011-04-20 21:01:48 PDT
Comment on attachment 90456 [details]

Comment 8 Roland Steiner 2011-04-21 10:26:07 PDT
Created attachment 90552 [details]
patch, cleanup, added WebKit parts

New patch, including cleanup after Dominics patch remarks, and added bits for Source/WebKit.
Comment 9 Dimitri Glazkov (Google) 2011-04-21 10:27:44 PDT
Comment on attachment 90552 [details]
patch, cleanup, added WebKit parts

even niftier.
Comment 10 Roland Steiner 2011-04-21 10:44:27 PDT
Committed r84520: <http://trac.webkit.org/changeset/84520>
Comment 11 WebKit Review Bot 2011-04-21 11:24:41 PDT
http://trac.webkit.org/changeset/84520 might have broken Qt Linux ARMv7 Release and Qt Windows 32-bit Debug