|Summary:||media/video-controls-transformed.html is broken|
|Product:||WebKit||Reporter:||Ami Fischman <fischman>|
|Component:||Media||Assignee:||Ami Fischman <fischman>|
|Severity:||Normal||CC:||commit-queue, levin, pnormand|
|Version:||528+ (Nightly build)|
Description Ami Fischman 2011-04-14 15:51:10 PDT
media/video-controls-transformed.html is ignored by all ports, and is broken because it hard-coded click locations for a control that varies by port (and has moved within ports, too).
Comment 1 Ami Fischman 2011-04-14 15:54:18 PDT
Created attachment 89677 [details] Stop hard-coding pixel values.
Comment 2 David Levin 2011-04-15 14:03:36 PDT
Comment on attachment 89677 [details] Stop hard-coding pixel values. View in context: https://bugs.webkit.org/attachment.cgi?id=89677&action=review > LayoutTests/media/video-controls-transformed.html:22 > + // This hard-codes the contruction order of the media controls, typo: contruction > LayoutTests/media/video-controls-transformed.html:23 > + // but is currently the only way to do it. http://webk.it/58584 typo: "but is" (Perhaps "but that is") typo: http://webk.it/58584
Comment 3 Ami Fischman 2011-04-25 21:03:55 PDT
(In reply to comment #2) > (From update of attachment 89677 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=89677&action=review > > > LayoutTests/media/video-controls-transformed.html:22 > > + // This hard-codes the contruction order of the media controls, > > typo: contruction Done. > > LayoutTests/media/video-controls-transformed.html:23 > > + // but is currently the only way to do it. http://webk.it/58584 > > typo: "but is" (Perhaps "but that is") I think the previous version was grammatically correct, but attempted a clarification. > typo: http://webk.it/58584 What's the typo?
Comment 5 David Levin 2011-04-25 23:03:15 PDT
Comment on attachment 91050 [details] CR1 responses. View in context: https://bugs.webkit.org/attachment.cgi?id=91050&action=review > LayoutTests/media/video-controls-transformed.html:24 > + // way to do it. http://webk.it/58584 is tracking fixing that. Cute: webk.it but it doesn't feel like it belongs in code like this when it really isn't controlled by the project. (It seems odd to me at least.)
Comment 7 WebKit Commit Bot 2011-04-26 22:07:38 PDT
Comment on attachment 91133 [details] CR2 responses. Clearing flags on attachment: 91133 Committed r85015: <http://trac.webkit.org/changeset/85015>
Comment 8 WebKit Commit Bot 2011-04-26 22:07:43 PDT
All reviewed patches have been landed. Closing bug.