Bug 58590

Summary:

media/video-controls-transformed.html is broken

Product:

WebKit

Reporter:

Ami Fischman <fischman>

Component:

Media

Assignee:

Ami Fischman <fischman>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, levin, pnormand

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

All

Attachments:

Description	Flags
Stop hard-coding pixel values.	none
CR1 responses.	none
CR2 responses.	none

Ami Fischman

Reported 2011-04-14 15:51:10 PDT

media/video-controls-transformed.html is ignored by all ports, and is broken because it hard-coded click locations for a control that varies by port (and has moved within ports, too).

Attachments
Stop hard-coding pixel values. (3.25 KB, patch) 2011-04-14 15:54 PDT, Ami Fischman	no flags	Details Formatted Diff Diff
CR1 responses. (3.32 KB, patch) 2011-04-25 21:05 PDT, Ami Fischman	no flags	Details Formatted Diff Diff
CR2 responses. (3.37 KB, patch) 2011-04-26 11:42 PDT, Ami Fischman	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Ami Fischman

Comment 1 2011-04-14 15:54:18 PDT

Created attachment 89677 [details] Stop hard-coding pixel values.

David Levin

Comment 2 2011-04-15 14:03:36 PDT

Comment on attachment 89677 [details] Stop hard-coding pixel values. View in context: https://bugs.webkit.org/attachment.cgi?id=89677&action=review > LayoutTests/media/video-controls-transformed.html:22 > + // This hard-codes the contruction order of the media controls, typo: contruction > LayoutTests/media/video-controls-transformed.html:23 > + // but is currently the only way to do it. http://webk.it/58584 typo: "but is" (Perhaps "but that is") typo: http://webk.it/58584

Ami Fischman

Comment 3 2011-04-25 21:03:55 PDT

(In reply to comment #2) > (From update of attachment 89677 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=89677&action=review > > > LayoutTests/media/video-controls-transformed.html:22 > > + // This hard-codes the contruction order of the media controls, > > typo: contruction Done. > > LayoutTests/media/video-controls-transformed.html:23 > > + // but is currently the only way to do it. http://webk.it/58584 > > typo: "but is" (Perhaps "but that is") I think the previous version was grammatically correct, but attempted a clarification. > typo: http://webk.it/58584 What's the typo?

Ami Fischman

Comment 4 2011-04-25 21:05:31 PDT

Created attachment 91050 [details] CR1 responses.

David Levin

Comment 5 2011-04-25 23:03:15 PDT

Comment on attachment 91050 [details] CR1 responses. View in context: https://bugs.webkit.org/attachment.cgi?id=91050&action=review > LayoutTests/media/video-controls-transformed.html:24 > + // way to do it. http://webk.it/58584 is tracking fixing that. Cute: webk.it but it doesn't feel like it belongs in code like this when it really isn't controlled by the project. (It seems odd to me at least.)

Ami Fischman

Comment 6 2011-04-26 11:42:08 PDT

Created attachment 91133 [details] CR2 responses.

WebKit Commit Bot

Comment 7 2011-04-26 22:07:38 PDT

Comment on attachment 91133 [details] CR2 responses. Clearing flags on attachment: 91133 Committed r85015: <http://trac.webkit.org/changeset/85015>

WebKit Commit Bot

Comment 8 2011-04-26 22:07:43 PDT

All reviewed patches have been landed. Closing bug.

Philippe Normand

Comment 9 2011-05-03 02:13:03 PDT

*** Bug 50706 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.