| Summary: | media/video-controls-transformed.html is broken | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ami Fischman <fischman> | ||||||||
| Component: | Media | Assignee: | Ami Fischman <fischman> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, levin, pnormand | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | PC | ||||||||||
| OS: | All | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Ami Fischman
2011-04-14 15:51:10 PDT
Created attachment 89677 [details]
Stop hard-coding pixel values.
Comment on attachment 89677 [details] Stop hard-coding pixel values. View in context: https://bugs.webkit.org/attachment.cgi?id=89677&action=review > LayoutTests/media/video-controls-transformed.html:22 > + // This hard-codes the contruction order of the media controls, typo: contruction > LayoutTests/media/video-controls-transformed.html:23 > + // but is currently the only way to do it. http://webk.it/58584 typo: "but is" (Perhaps "but that is") typo: http://webk.it/58584 (In reply to comment #2) > (From update of attachment 89677 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=89677&action=review > > > LayoutTests/media/video-controls-transformed.html:22 > > + // This hard-codes the contruction order of the media controls, > > typo: contruction Done. > > LayoutTests/media/video-controls-transformed.html:23 > > + // but is currently the only way to do it. http://webk.it/58584 > > typo: "but is" (Perhaps "but that is") I think the previous version was grammatically correct, but attempted a clarification. > typo: http://webk.it/58584 What's the typo? Created attachment 91050 [details]
CR1 responses.
Comment on attachment 91050 [details] CR1 responses. View in context: https://bugs.webkit.org/attachment.cgi?id=91050&action=review > LayoutTests/media/video-controls-transformed.html:24 > + // way to do it. http://webk.it/58584 is tracking fixing that. Cute: webk.it but it doesn't feel like it belongs in code like this when it really isn't controlled by the project. (It seems odd to me at least.) Created attachment 91133 [details]
CR2 responses.
Comment on attachment 91133 [details] CR2 responses. Clearing flags on attachment: 91133 Committed r85015: <http://trac.webkit.org/changeset/85015> All reviewed patches have been landed. Closing bug. |