Bug 5846

Summary:

cvs-create-patch --include produces incorrect paths

Product:

WebKit

Reporter:

Oliver Hunt <oliver>

Component:

Tools / Tests

Assignee:

Oliver Hunt <oliver>

Status:

RESOLVED FIXED

Severity:

Minor

CC:

Priority:

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

Bug Depends on:

Bug Blocks:

5845

Attachments:

Description	Flags
patch to fix problem	none
additional patch	darin: review+

Oliver Hunt

Reported 2005-11-27 16:30:09 PST

cvs-create-patch --include produces truncated paths for new files

Attachments
patch to fix problem (449 bytes, patch) 2005-11-27 16:31 PST, Oliver Hunt	no flags	Details Formatted Diff Diff
additional patch (2.16 KB, patch) 2005-12-20 05:32 PST, Alexey Proskuryakov	darin: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Oliver Hunt

Comment 1 2005-11-27 16:31:19 PST

Created attachment 4823 [details] patch to fix problem

Maciej Stachowiak

Comment 2 2005-11-27 16:47:12 PST

Comment on attachment 4823 [details] patch to fix problem r=me please use unidiff (cvs diff -u) format for future patches.

mitz

Comment 3 2005-12-03 08:52:34 PST

The paths I'm seeing for unknown files after the patch are missing the penultimate path component, e.g LayoutTests/fast/sometest.html instead of LayoutTests/fast/js/sometest.html I suspect this line in addNewFile: $indexPath =~ s|[^/]+$|| if defined $indexPath;

Darin Adler

Comment 4 2005-12-03 16:06:22 PST

Comment on attachment 4823 [details] patch to fix problem Clearing review flag since the patch has been landed but the bug reopened (and we don't want this in the "patches to be landed" list).

Alexey Proskuryakov

Comment 5 2005-12-20 05:32:57 PST

Created attachment 5181 [details] additional patch The current version didn't always omit the penultimate component, but could also duplicate it in some cases :)

Darin Adler

Comment 6 2005-12-20 09:14:01 PST

Comment on attachment 5181 [details] additional patch Looks fine. r=me

Note You need to log in before you can comment on or make changes to this bug.