Bug 5846 - cvs-create-patch --include produces incorrect paths
Summary: cvs-create-patch --include produces incorrect paths
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P4 Minor
Assignee: Oliver Hunt
URL:
Keywords:
Depends on:
Blocks: 5845
  Show dependency tree / graph
 
Reported: 2005-11-27 16:30 PST by Oliver Hunt
Modified: 2005-12-21 23:39 PST (History)
1 user (show)

See Also:

Attachments
patch to fix problem (449 bytes, patch)
2005-11-27 16:31 PST, Oliver Hunt 		no flags Details | Formatted Diff | Diff
additional patch (2.16 KB, patch)
2005-12-20 05:32 PST, Alexey Proskuryakov 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2005-11-27 16:30:09 PST 
cvs-create-patch --include produces truncated paths for new files
Comment 1 Oliver Hunt 2005-11-27 16:31:19 PST 
Created attachment 4823 [details]
patch to fix problem
Comment 2 Maciej Stachowiak 2005-11-27 16:47:12 PST 
Comment on attachment 4823 [details]
patch to fix problem

r=me please use unidiff (cvs diff -u) format for future patches.
Comment 3 mitz 2005-12-03 08:52:34 PST 
The paths I'm seeing for unknown files after the patch are missing the penultimate path component, e.g
LayoutTests/fast/sometest.html instead of LayoutTests/fast/js/sometest.html
I suspect this line in addNewFile:
    $indexPath =~ s|[^/]+$|| if defined $indexPath;
Comment 4 Darin Adler 2005-12-03 16:06:22 PST 
Comment on attachment 4823 [details]
patch to fix problem

Clearing review flag since the patch has been landed but the bug reopened (and
we don't want this in the "patches to be landed" list).
Comment 5 Alexey Proskuryakov 2005-12-20 05:32:57 PST 
Created attachment 5181 [details]
additional patch

The current version didn't always omit the penultimate component, but could
also duplicate it in some cases :)
Comment 6 Darin Adler 2005-12-20 09:14:01 PST 
Comment on attachment 5181 [details]
additional patch

Looks fine. r=me