Bug 5845

Summary:

cvs-create-patch --include produces incorrect paths and has issues with new files passed as args

Product:

WebKit

Reporter:

Oliver Hunt <oliver>

Component:

Tools / Tests

Assignee:

Oliver Hunt <oliver>

Status:

CLOSED INVALID

Severity:

Trivial

Priority:

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

Bug Depends on:

5846, 5847

Bug Blocks:

Attachments:

Description	Flags
This patches problem (2)	none

Oliver Hunt

Reported 2005-11-27 16:12:09 PST

cvs-create-patch has a couple of irritating flaws 1. It doesn't handle files/directories that don't exist in the local repository when they are passed as arguments 2. New files don't get the correct path attaached

Attachments
This patches problem (2) (449 bytes, patch) 2005-11-27 16:13 PST, Oliver Hunt	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Oliver Hunt

Comment 1 2005-11-27 16:13:51 PST

Created attachment 4822 [details] This patches problem (2) Okay this fixes problem (2) -- where the correct path is not given for new files. Unfortunately I don't know perl so can't be sure it's actually correct -- it produces the right output though, which i find promising.

Oliver Hunt

Comment 2 2005-11-27 16:34:20 PST

Split into two seperate bugs, bug #5846 and bug #5847

Maciej Stachowiak

Comment 3 2005-11-27 16:46:42 PST

obsoleted by the new bugs

Note You need to log in before you can comment on or make changes to this bug.