Summary: | Web Inspector: ResourceResponse should have encodedDataLength field for synchronous requests transfer size | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Vsevolod Vlasov <vsevik> | ||||||
Component: | Web Inspector (Deprecated) | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | apavlov, bweinstein, commit-queue, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Vsevolod Vlasov
2011-04-13 09:10:19 PDT
Created attachment 89386 [details]
Patch
Comment on attachment 89386 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=89386&action=review > Source/WebCore/loader/FrameLoader.cpp:2829 > + notifier()->sendRemainingDelegateMessages(m_documentLoader.get(), identifier, response, data.size(), static_cast<int>(response.encodedDataLength()), error); what are the implications of this change? > Source/WebCore/platform/network/ResourceResponseBase.h:68 > + long long encodedDataLength() const; This should be a part of ResourceLoadInfo. Created attachment 89558 [details] Patch (In reply to comment #2) > (From update of attachment 89386 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=89386&action=review > > > Source/WebCore/loader/FrameLoader.cpp:2829 > > + notifier()->sendRemainingDelegateMessages(m_documentLoader.get(), identifier, response, data.size(), static_cast<int>(response.encodedDataLength()), error); > > what are the implications of this change? This parameter was introduced by my previous change and the value passed here was not correct. Now we are passing a correct value that will be forwarded to didReceiveData. > > Source/WebCore/platform/network/ResourceResponseBase.h:68 > > + long long encodedDataLength() const; > > This should be a part of ResourceLoadInfo. Done. The commit-queue encountered the following flaky tests while processing attachment 89558 [details]: http/tests/misc/favicon-loads-with-icon-loading-override.html bug 58412 (author: alice.liu@apple.com) The commit-queue is continuing to process your patch. Comment on attachment 89558 [details] Patch Clearing flags on attachment: 89558 Committed r83942: <http://trac.webkit.org/changeset/83942> All reviewed patches have been landed. Closing bug. |