Bug 58411

Summary:

Merge LineOffsets and LineWidth

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

Layout and Rendering

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Enhancement

CC:

commit-queue, dglazkov, eric, hyatt, jamesr, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

57779

Attachments:

Description	Flags
cleanup	none

Description Ryosuke Niwa 2011-04-12 19:32:00 PDT

We should merge LineOffsets and LineWidth classes in RenderBlockLineLayout.cpp

Comment 1 Ryosuke Niwa 2011-04-12 20:00:10 PDT

Created attachment 89329 [details]
cleanup

Comment 2 Ryosuke Niwa 2011-04-13 11:32:11 PDT

ping?

Comment 3 Eric Seidel (no email) 2011-04-13 11:42:01 PDT

I'm not sure I fully understand the motivation of this change.  I can't tell if the code is better with it or not.

Comment 4 Ryosuke Niwa 2011-04-13 11:56:06 PDT

(In reply to comment #3)
> I'm not sure I fully understand the motivation of this change.  I can't tell if the code is better with it or not.

LineOffsets is used only to compute m_availableWidth, which is a member variable of LineWidth.  Combining these two classes allow us to encapsulate mutations of m_availableWidth entirely, and hide left/right mechanism we use internally to figure out the correct available width.

Comment 5 Eric Seidel (no email) 2011-04-13 11:58:13 PDT

Comment on attachment 89329 [details]
cleanup

OK.

Comment 6 WebKit Commit Bot 2011-04-13 17:58:57 PDT

Comment on attachment 89329 [details]
cleanup

Clearing flags on attachment: 89329

Committed r83794: <http://trac.webkit.org/changeset/83794>

Comment 7 WebKit Commit Bot 2011-04-13 17:59:03 PDT

All reviewed patches have been landed.  Closing bug.