Summary: | Merge LineOffsets and LineWidth | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||
Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Enhancement | CC: | commit-queue, dglazkov, eric, hyatt, jamesr, rniwa | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 57779 | ||||||
Attachments: |
|
Description
Ryosuke Niwa
2011-04-12 19:32:00 PDT
Created attachment 89329 [details]
cleanup
ping? I'm not sure I fully understand the motivation of this change. I can't tell if the code is better with it or not. (In reply to comment #3) > I'm not sure I fully understand the motivation of this change. I can't tell if the code is better with it or not. LineOffsets is used only to compute m_availableWidth, which is a member variable of LineWidth. Combining these two classes allow us to encapsulate mutations of m_availableWidth entirely, and hide left/right mechanism we use internally to figure out the correct available width. Comment on attachment 89329 [details]
cleanup
OK.
Comment on attachment 89329 [details] cleanup Clearing flags on attachment: 89329 Committed r83794: <http://trac.webkit.org/changeset/83794> All reviewed patches have been landed. Closing bug. |