Summary: | compositing/objects/composited-object-alignment.html causing failures in other tests since its introduction in r83518 | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jessie Berlin <jberlin> | ||||
Component: | Layout and Rendering | Assignee: | Chris Marrin <cmarrin> | ||||
Status: | ASSIGNED --- | ||||||
Severity: | Normal | CC: | ahmad.saleem792, aroben, cmarrin, jberlin, simon.fraser, tonikitoo, webkit.review.bot | ||||
Priority: | P2 | Keywords: | InRadar, LayoutTestFailure | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=167537 | ||||||
Attachments: |
|
Description
Jessie Berlin
2011-04-12 08:26:59 PDT
Disabled the test in http://trac.webkit.org/changeset/83588 (In reply to comment #0) > http://build.webkit.org/results/Windows%207%20Release%20(Tests)/r83519%20(11485)/compositing/overflow/ancestor-overflow-pretty-diff.html > > The error there is coming from the code in LayoutTests/compositing/objects/resources/composited-subframe.html, which is used by composited-object-alignment, and is a bit buggy: > 1)It uses setTimeout without first calling layoutTestController.waitUntilDone. > 2)It tries to call some nonexistent parent.testDone() function. This is cruft I failed to get rid of when changing the test to do a pixel test rather than printing the layer tree. I'll get rid of it. > 3)The platform-specific results are sitting in the cross-platform directory. The intent is for all the results to be cross-platform. I avoided text and borders and anything else that would cause differences in the pixel results. Looks like pixel results don't match up, at least not between WebKit and WebKit2. So I will just generate platform specific results for all cases Created attachment 89224 [details]
Patch
Comment on attachment 89224 [details]
Patch
Looks like LayoutTests/platform/mac/compositing/objects/composited-object-alignment-expected.png has the wrong mime type.
Comment on attachment 89224 [details] Patch Rejecting attachment 89224 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-01', '--port..." exit_code: 2 Last 500 characters of output: annot stat `LayoutTests/compositing/objects/composited-object-alignment-expected.checksum': No such file or directory Failed to copy LayoutTests/compositing/objects/composited-object-alignment-expected.checksum LayoutTests/platform/mac/compositing/objects/composited-object-alignment-expected.checksum. at /mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply line 428. Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Simon Fraser', u'--for..." exit_code: 2 Full output: http://queues.webkit.org/results/8881917 |