Bug 58296

Summary: new-run-webkit-tests: configure logging in child processes properly
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: New BugsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, mihaip, ojan, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 55163    
Attachments:
Description Flags
Patch ojan: review+

Description Dirk Pranke 2011-04-11 20:04:07 PDT
new-run-webkit-tests: configure logging in child processes properly
Comment 1 Dirk Pranke 2011-04-11 20:05:03 PDT
Created attachment 89148 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-04-12 10:59:24 PDT
Comment on attachment 89148 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=89148&action=review

I don't really understand what this chagne does.

> Tools/Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:322
> +            # FIXME: this won't work if the calling process is logging

nit: "This" since it starts the sentence.
Comment 3 Dirk Pranke 2011-04-12 11:26:31 PDT
(In reply to comment #2)
> (From update of attachment 89148 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=89148&action=review
> 
> I don't really understand what this chagne does.
> 

This change is modifying the code that runs in the child processes when NRWT is running in multi-process mode. Specifically, it is modifying the logging configuration to match the configuration in the master/parent process. This wasn't needed on Unix since the configuration is cloned through fork(), but the windows code doesn't fork(), so we have to explicitly reconfigure it.

> > Tools/Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:322
> > +            # FIXME: this won't work if the calling process is logging
> 
> nit: "This" since it starts the sentence.

Will fix when I land or in the next patch if other changes are needed.
Comment 4 Dirk Pranke 2011-04-13 14:01:18 PDT
Committed r83760: <http://trac.webkit.org/changeset/83760>