Bug 58243

Summary:

fix crc computation on 64 bit machines

Product:

WebKit

Reporter:

Tony Chang <tony>

Component:

New Bugs

Assignee:

Tony Chang <tony>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, eric

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Bug Depends on:

Bug Blocks:

58173

Attachments:

Description	Flags
Patch	eric: review+

Description Tony Chang 2011-04-11 09:51:53 PDT

fix crc computation on 64 bit machines

Comment 1 Tony Chang 2011-04-11 09:53:43 PDT

Created attachment 89019 [details]
Patch

Comment 2 Eric Seidel (no email) 2011-04-11 11:25:35 PDT

Comment on attachment 89019 [details]
Patch

I like this change.  No way to test it?

Comment 3 Tony Chang 2011-04-11 11:36:37 PDT

Committed r83461: <http://trac.webkit.org/changeset/83461>

Comment 4 Tony Chang 2011-04-11 11:37:40 PDT

(In reply to comment #2)
> (From update of attachment 89019 [details])
> No way to test it?

AFAIK, there's no way to write tests for DRT code.

Comment 5 Alexey Proskuryakov 2011-04-11 15:05:43 PDT

Why not uint32_t? Unlike unsigned, it's actually really always 32 bit.

Comment 6 Tony Chang 2011-04-11 16:24:59 PDT

(In reply to comment #5)
> Why not uint32_t? Unlike unsigned, it's actually really always 32 bit.

It looks like stdint.h isn't included with MSVC, but there's a copy in Source/JavaScriptCore/os-win32 that has uint32_t defined.  It seems like I could either change the include path on win and win-cairo or just #if COMPILER(MSVC) the typedef.  Does one of these sound like the preferred way to you, Alexey?