| Summary: | new-run-webkit-tests: implement support for audio, take two | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dirk Pranke <dpranke> | ||||
| Component: | New Bugs | Assignee: | Dirk Pranke <dpranke> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, crogers, eric, mihaip, ojan, tony | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Other | ||||||
| OS: | OS X 10.5 | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 58196 | ||||||
| Attachments: |
|
||||||
|
Description
Dirk Pranke
2011-04-09 19:11:19 PDT
Created attachment 88940 [details]
Patch
Comment on attachment 88940 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=88940&action=review This is a revised version of the patch(es) landed in bug 58101. Those patches were rolled out because they were crashing new-run-webkit-tests. The regression turned out to be a result of passing None instead of '' to Port.diff_image(). I have added comments to show the diffs from the previous patch. > Tools/Scripts/webkitpy/layout_tests/port/chromium.py:143 > + return True This chunk is the fix for the crash on diff_image() in chromium ports. This really needs unit tests, but to test it properly requires changing too many other things, so I'll post the unit tests in a separate patch for clarity. > Tools/Scripts/webkitpy/layout_tests/port/webkit.py:115 > + if not actual_contents or not expected_contents: And this is the fix for the webkit-base ports. Again, I will post unit tests in a separate patch for clarity. Committed r83475: <http://trac.webkit.org/changeset/83475> |