Summary: | Add stub support for generating Gtk build system from gyp | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> | ||||||||
Component: | New Bugs | Assignee: | Eric Seidel (no email) <eric> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | abarth, mrobinson, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Other | ||||||||||
OS: | OS X 10.5 | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 55018 | ||||||||||
Attachments: |
|
Description
Eric Seidel (no email)
2011-04-07 14:58:13 PDT
Created attachment 88708 [details]
Patch
Comment on attachment 88708 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=88708&action=review > Source/JavaScriptCore/gyp/gtk.gyp:11 > + 'variables': { > + 'javascriptcore_include_dirs': [ > + '<(project_dir)', > + '<(project_dir)/icu', > + ], > + }, I'd skip this part. This isn't correct because Gtk doesn't have header maps. Created attachment 88714 [details]
Patch for landing
Created attachment 88720 [details]
Patch
Attachment 88720 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'Source/JavaScriptCore/Change..." exit_code: 1
Source/ThirdParty/gyp/pylib/gyp/generator/filelist.py:25: indentation is not a multiple of four [pep8/E111] [5]
Source/ThirdParty/gyp/pylib/gyp/generator/filelist.py:27: indentation is not a multiple of four [pep8/E111] [5]
Source/ThirdParty/gyp/pylib/gyp/generator/filelist.py:30: indentation is not a multiple of four [pep8/E111] [5]
Source/ThirdParty/gyp/pylib/gyp/generator/filelist.py:32: at least two spaces before inline comment [pep8/E261] [5]
Source/ThirdParty/gyp/pylib/gyp/generator/filelist.py:37: indentation is not a multiple of four [pep8/E111] [5]
Source/ThirdParty/gyp/pylib/gyp/generator/filelist.py:40: at least two spaces before inline comment [pep8/E261] [5]
Total errors found: 6 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Committed r83225: <http://trac.webkit.org/changeset/83225> |