|Summary:||Should assert on invalid type in FEComponentTransfer::apply|
|Product:||WebKit||Reporter:||Justin Schuh <jschuh>|
|Component:||New Bugs||Assignee:||Justin Schuh <jschuh>|
|Severity:||Normal||CC:||commit-queue, eric, krit, zimmermann|
|Version:||528+ (Nightly build)|
|OS:||OS X 10.5|
Description Justin Schuh 2011-04-06 10:06:47 PDT
Should assert on invalid type in FEComponentTransfer::apply
Comment 2 Eric Seidel (no email) 2011-04-06 10:54:43 PDT
Comment on attachment 88459 [details] Patch Makes sense.
Comment 3 Eric Seidel (no email) 2011-04-06 10:55:47 PDT
Comment on attachment 88459 [details] Patch Actually, shouldn't we do this before we loop over all the rgba values (in a separate loop?) This seems it would make debug behavior needlessly slow.
Comment 4 Justin Schuh 2011-04-06 11:02:06 PDT
(In reply to comment #3) > (From update of attachment 88459 [details]) > Actually, shouldn't we do this before we loop over all the rgba values (in a separate loop?) This seems it would make debug behavior needlessly slow. I think this way is easier to follow than a duplicate loop blocked out with debug #ifdefs. And since it's an assert (that doesn't affect release), I think readability should be the priority.
Comment 5 Justin Schuh 2011-04-21 15:54:15 PDT
Eric, did I sufficiently respond to your question and do you have any objection to me landing it?
Comment 6 Eric Seidel (no email) 2011-04-22 09:18:12 PDT
I'm not standing in the way of this patch, no, you're welcome to land.
Comment 7 Justin Schuh 2011-04-22 10:08:50 PDT
(In reply to comment #6) > I'm not standing in the way of this patch, no, you're welcome to land. Thanks. It slipped off my radar and I was trying to do some cleanup.
Comment 8 WebKit Commit Bot 2011-04-22 11:48:29 PDT
The commit-queue encountered the following flaky tests while processing attachment 88459 [details]: http/tests/misc/favicon-loads-with-icon-loading-override.html bug 58412 (author: email@example.com) The commit-queue is continuing to process your patch.
Comment 9 WebKit Commit Bot 2011-04-22 12:28:07 PDT
Comment on attachment 88459 [details] Patch Rejecting attachment 88459 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-8', 'apply-..." exit_code: 2 Last 500 characters of output: " exit_code: 1 Parsed 2 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/platform/graphics/filters/FEComponentTransfer.cpp Hunk #1 FAILED at 33. Hunk #2 FAILED at 170. 2 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/platform/graphics/filters/FEComponentTransfer.cpp.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Eric Seidel', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/8486842