| Summary: | Split getBorderPaddingMargin into two functions | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, commit-queue, dglazkov, eric, hyatt, rniwa, simon.fraser, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | PC | ||||||
| OS: | OS X 10.5 | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 57779 | ||||||
| Attachments: |
|
||||||
|
Description
Ryosuke Niwa
2011-04-06 07:34:00 PDT
Created attachment 88425 [details]
cleanup
Comment on attachment 88425 [details] cleanup View in context: https://bugs.webkit.org/attachment.cgi?id=88425&action=review > Source/WebCore/rendering/RenderBlockLineLayout.cpp:66 > + // FIXME: Should we call marginStartForChild instead? > return child->marginStart() + child->paddingStart() + child->borderStart(); It's really odd that we don't call marginStartForChild here. This is almost the only place we call marginStart instead. Dave & Simon, this is correct? Comment on attachment 88425 [details] cleanup View in context: https://bugs.webkit.org/attachment.cgi?id=88425&action=review ok. > Source/WebCore/ChangeLog:7 > + Usually I put in something explaining why there aren't tests. Like: Refactoring, covered by existing tests. Or Refactoring, no functional change. Comment on attachment 88425 [details] cleanup Clearing flags on attachment: 88425 Committed r83066: <http://trac.webkit.org/changeset/83066> All reviewed patches have been landed. Closing bug. http://trac.webkit.org/changeset/83066 might have broken GTK Linux 32-bit Release The following tests are not passing: fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element.html fast/dom/HTMLProgressElement/progress-element.html |