Summary: | Change EventHandler::updateSelectionForMouseDrag to take a HitTestResult only. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alice Boxhall <aboxhall> | ||||||
Component: | WebKit Misc. | Assignee: | Alice Boxhall <aboxhall> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | aboxhall, ap, commit-queue, noel.gordon, rniwa | ||||||
Priority: | P3 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | OS X 10.5 | ||||||||
Bug Depends on: | 57921 | ||||||||
Bug Blocks: | 55552 | ||||||||
Attachments: |
|
Description
Alice Boxhall
2011-04-05 23:06:17 PDT
Created attachment 88731 [details]
Patch
Comment on attachment 88731 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=88731&action=review > Source/WebCore/page/EventHandler.cpp:631 > + Node* targetNode = EventHandler::targetNode(hitTestResult); > if (!targetNode) You should probably rename the local variable so that you don't have to resolve the name of member function like this. > Source/WebCore/page/EventHandler.cpp:642 > + IntPoint localPoint = hitTestResult.localPoint(); > + VisiblePosition targetPosition = targetRenderer->positionForPoint(localPoint); Why do you need to declare a local variable fot IntPoint? Comment on attachment 88731 [details]
Patch
r- per the above comments. otherwise, this is a nice cleanup.
Created attachment 88961 [details]
Patch
(In reply to comment #2) > (From update of attachment 88731 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=88731&action=review > > > Source/WebCore/page/EventHandler.cpp:631 > > + Node* targetNode = EventHandler::targetNode(hitTestResult); > > if (!targetNode) > > You should probably rename the local variable so that you don't have to resolve the name of member function like this. Done. > > Source/WebCore/page/EventHandler.cpp:642 > > + IntPoint localPoint = hitTestResult.localPoint(); > > + VisiblePosition targetPosition = targetRenderer->positionForPoint(localPoint); > > Why do you need to declare a local variable fot IntPoint? No reason. Comment on attachment 88961 [details] Patch Clearing flags on attachment: 88961 Committed r83414: <http://trac.webkit.org/changeset/83414> All reviewed patches have been landed. Closing bug. |