Bug 57910

Summary: Rename CSSKeyframesRule insertRule to appendRule
Product: WebKit Reporter: Dean Jackson <dino>
Component: CSSAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, sabouhallawa, simon.fraser
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: OS X 10.5   
See Also: https://bugs.webkit.org/show_bug.cgi?id=247364
Attachments:
Description Flags
Patch none

Dean Jackson
Reported 2011-04-05 18:00:54 PDT
The spec renamed the method. Make sure we don't remove the existing insertRule though, in case people are using it.
Attachments
Patch (3.63 KB, patch)
2014-09-25 15:58 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dean Jackson
Comment 1 2011-04-05 18:02:00 PDT
<rdar://problem/9237118>
Sylvain Galineau
Comment 2 2014-07-19 12:02:53 PDT
*** Bug 133746 has been marked as a duplicate of this bug. ***
Said Abou-Hallawa
Comment 3 2014-09-25 12:59:56 PDT
I have a fix for this bug. The interface WebKitCSSKeyframesRule.idl and the class WebKitCSSKeyframesRule need to have a new method called 'appendRule' which is basically and alias of InsertRule().
Said Abou-Hallawa
Comment 4 2014-09-25 15:58:48 PDT
Created attachment 238680 [details] Patch
WebKit Commit Bot
Comment 5 2014-09-25 17:03:45 PDT
Comment on attachment 238680 [details] Patch Clearing flags on attachment: 238680 Committed r173982: <http://trac.webkit.org/changeset/173982>
WebKit Commit Bot
Comment 6 2014-09-25 17:03:49 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.