| Summary: | cmake fixes to build efl port under macosx too | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Onne Gorter <o.gorter> | ||||||||
| Component: | WebKit EFL | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED DUPLICATE | ||||||||||
| Severity: | Normal | CC: | rakuco | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | PC | ||||||||||
| OS: | OS X 10.5 | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 87491 [details]
move public destructor to wtf or wtf by itself won't link
actually, you can only build webkit with ICU on a case sensitive file system! Because JavaScriptCore/wtf/unicode/UTF8.h and <unicode/utf8.h> from ICU will be ambiguous. (Don't make the whole macosx harddrive case sensitive, this will break certain programs, instead create a disk image with a case sensitive partition.) to make the rest work, in wtf/Platform.h: #define WTF_PLATFORM_MAC 0 #define ENABLE_PURGEABLE_MEMORY 0 or (haven't tried) add WebCore/platform/mac/PurgeableBufferMac.cpp to WebCore/CMakeLists.txt will update cmake patch Created attachment 87526 [details]
cmake macosx build fix (Efl port)
Hi there. Please attach only one patch per bug, so that when it is committed the bug can be automatically closed. You should add some people to the CC list for it to be reviewed (it's easier if you use the webkit-patch script in Tools/Scripts). You also need to mark you patch for review and commit-queue (by clicking in the "Details" link) so that it is tested against various ports. Can you then create more bug reports if needed and check if your patches build against the latest SVN revision? |
Created attachment 87490 [details] cmake patch to allow building under macosx there are a few issues that prevent the efl port to build under macosx, this fixes most of them, though manually fixing up wtf/Platform.h is likely required ... two independed patches: one to fix the cmake files to behave a bit bitter, should work and be useful under linux too one to fix (temporary) weird layering issue in wtf vs jsc on IdentifierTable, likely fixed in the future already, only needed when compiling with shared core