Bug 57412
| Summary: | check-webkit-style lied about bug numbers in my ChangeLogs | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Beth Dakin <bdakin> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | bdakin, levin, paroga |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | OS X 10.5 | ||
Beth Dakin
See: https://bugs.webkit.org/show_bug.cgi?id=57408
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Beth Dakin
See also: https://bugs.webkit.org/show_bug.cgi?id=57605
David Levin
Patrick, could you look into fixing these? We strive to have a very low false positive rate to avoid annoying people with check-webkit-style.
Patrick R. Gansterer
(In reply to comment #2)
> Patrick, could you look into fixing these? We strive to have a very low false positive rate to avoid annoying people with check-webkit-style.
Do you know what the style-queue does with the patch? When I apply the patch to my git woking copy and run "Tools/Scripts/check-webkit-style --diff-files Source/WebCore/ChangeLog", I don't get an error. When I remove the valid bug number from the change in my working copy, it shows an error. So check-webkit-style seams to process the correct change.
Unfortunately I'm not able to reproduce this error on my Mac with git repository.
An other example of wrong bug number handling is https://bugs.webkit.org/attachment.cgi?id=87693&action=review.
The dot at the end of the line seams to confuse check-webkit-style.