Summary: | JavaInstance should not use jvalue in its API | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Steve Block <steveblock> | ||||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | andreip, commit-queue, jorlow, steveblock | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Bug Depends on: | 57022 | ||||||||
Bug Blocks: | 55383 | ||||||||
Attachments: |
|
Description
Steve Block
2011-03-24 08:47:39 PDT
This bug tracks fixing only the V8 version of JavaInstance. The JSC version can not be fixed until Bug 57023 is fixed. Created attachment 87296 [details]
Patch
LGTM View in context: https://bugs.webkit.org/attachment.cgi?id=87296&action=review > Source/WebCore/bridge/jni/v8/JavaInstanceV8.cpp:76 > + jvalue* jvalueArgs = new jvalue[numParams]; Is there a scoped_pointer for arrays? > Source/WebCore/bridge/jni/v8/JavaInstanceV8.cpp:78 > + jvalueArgs[i] = javaValueToJvalue(args[i]); Maybe add a comment to say that args is guaranteed to have at least numParams elements. > Is there a scoped_pointer for arrays? Yes - OwnArrayPtr - fixed. > Maybe add a comment to say that args is guaranteed to have at least numParams elements. I've added a comment in the header. Note that this is not a new requirement, as previously the array was passed straight through to callJNIMethod(). Created attachment 87413 [details]
Patch
Comment on attachment 87413 [details]
Patch
r+ based on Andrei's review
Comment on attachment 87413 [details] Patch Clearing flags on attachment: 87413 Committed r82361: <http://trac.webkit.org/changeset/82361> All reviewed patches have been landed. Closing bug. |