Bug 56921

Summary: Media Stream API: add a flag to RuntimeEnabledFeatures.
Product: WebKit Reporter: Leandro Graciá Gil <leandrogracia>
Component: DOMAssignee: Leandro Graciá Gil <leandrogracia>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, satish, steveblock
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 56458    
Bug Blocks: 56586    
Attachments:
Description Flags
Patch none

Description Leandro Graciá Gil 2011-03-23 06:43:30 PDT
Add a flag to RuntimeEnabledFeatures to check if the Media Stream API is enabled at runtime.
Comment 1 Leandro Graciá Gil 2011-03-23 06:48:19 PDT
Created attachment 86610 [details]
Patch
Comment 2 Steve Block 2011-03-23 07:00:23 PDT
Comment on attachment 86610 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=86610&action=review

> Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp:61
> +bool RuntimeEnabledFeatures::isMediaStreamEnabled = true;

Are sure you want this enabled by default?
Comment 3 Leandro Graciá Gil 2011-03-23 07:38:07 PDT
Comment on attachment 86610 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=86610&action=review

>> Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp:61
>> +bool RuntimeEnabledFeatures::isMediaStreamEnabled = true;
> 
> Are sure you want this enabled by default?

At least for the moment, yes. This is probably going to be changed later.
Comment 4 WebKit Commit Bot 2011-03-23 09:48:12 PDT
Comment on attachment 86610 [details]
Patch

Clearing flags on attachment: 86610

Committed r81779: <http://trac.webkit.org/changeset/81779>
Comment 5 WebKit Commit Bot 2011-03-23 09:48:17 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 WebKit Commit Bot 2011-03-23 10:14:34 PDT
The commit-queue encountered the following flaky tests while processing attachment 86610 [details]:

fast/images/load-img-with-empty-src.html bug 50855 (author: mitz@webkit.org)
The commit-queue is continuing to process your patch.
Comment 7 WebKit Commit Bot 2011-03-23 10:57:49 PDT
The commit-queue encountered the following flaky tests while processing attachment 86610 [details]:

media/invalid-media-url-crash.html bug 51138 (authors: inferno@chromium.org and jamesr@chromium.org)
The commit-queue is continuing to process your patch.