RESOLVED FIXED 56921
Media Stream API: add a flag to RuntimeEnabledFeatures.
https://bugs.webkit.org/show_bug.cgi?id=56921
Summary Media Stream API: add a flag to RuntimeEnabledFeatures.
Leandro Graciá Gil
Reported Wednesday, March 23, 2011 2:43:30 PM UTC
Add a flag to RuntimeEnabledFeatures to check if the Media Stream API is enabled at runtime.
Attachments
Patch (2.84 KB, patch)
2011-03-23 06:48 PDT, Leandro Graciá Gil
no flags
Leandro Graciá Gil
Comment 1 Wednesday, March 23, 2011 2:48:19 PM UTC
Steve Block
Comment 2 Wednesday, March 23, 2011 3:00:23 PM UTC
Comment on attachment 86610 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=86610&action=review > Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp:61 > +bool RuntimeEnabledFeatures::isMediaStreamEnabled = true; Are sure you want this enabled by default?
Leandro Graciá Gil
Comment 3 Wednesday, March 23, 2011 3:38:07 PM UTC
Comment on attachment 86610 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=86610&action=review >> Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp:61 >> +bool RuntimeEnabledFeatures::isMediaStreamEnabled = true; > > Are sure you want this enabled by default? At least for the moment, yes. This is probably going to be changed later.
WebKit Commit Bot
Comment 4 Wednesday, March 23, 2011 5:48:12 PM UTC
Comment on attachment 86610 [details] Patch Clearing flags on attachment: 86610 Committed r81779: <http://trac.webkit.org/changeset/81779>
WebKit Commit Bot
Comment 5 Wednesday, March 23, 2011 5:48:17 PM UTC
All reviewed patches have been landed. Closing bug.
WebKit Commit Bot
Comment 6 Wednesday, March 23, 2011 6:14:34 PM UTC
The commit-queue encountered the following flaky tests while processing attachment 86610 [details]: fast/images/load-img-with-empty-src.html bug 50855 (author: mitz@webkit.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 7 Wednesday, March 23, 2011 6:57:49 PM UTC
The commit-queue encountered the following flaky tests while processing attachment 86610 [details]: media/invalid-media-url-crash.html bug 51138 (authors: inferno@chromium.org and jamesr@chromium.org) The commit-queue is continuing to process your patch.
Note You need to log in before you can comment on or make changes to this bug.