Teach update-webkit about gyp

• Component: New Bugs
• Status: RESOLVED FIXED

[Eric Seidel (no email)]

Teach update-webkit about gyp

[Eric Seidel (no email)]

Created attachment 86547 [details]
Patch

[Adam Barth]

Comment on attachment 86547 [details]
Patch

ok.

[Adam Barth]

Comment on attachment 86547 [details]
Patch

Clearing flags on attachment: 86547

Committed r81735: <http://trac.webkit.org/changeset/81735>

[Adam Barth]

All reviewed patches have been landed.  Closing bug.

[Mark Rowe (bdash)]

Comment on attachment 86547 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=86547&action=review

> Tools/Scripts/generate-project-files:37
> +# This allows building from Source without a copy of Tools (as Apple's internal builds do).

Note that this doesn’t help our builds at all since the builds in question check out using “svn export”, not using any WebKit scripts.

[Mark Rowe (bdash)]

In other words, that part of the comment is misleading as-is so I’m not sure why it’s present.

[Adam Barth]

(In reply to comment #5)
> (From update of attachment 86547 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=86547&action=review
> 
> > Tools/Scripts/generate-project-files:37
> > +# This allows building from Source without a copy of Tools (as Apple's internal builds do).
> 
> Note that this doesn’t help our builds at all since the builds in question check out using “svn export”, not using any WebKit scripts.
>
> In other words, that part of the comment is misleading as-is so I’m not sure why it’s present.

You obviously know more about the Apple internal build system than I do.  The comment is meant to explain that we have two scripts in order to make Source buildable without Tools.  As an example of such a situation, Tools is not an input into Apple's internal build system.  We can certainly update the comment to explain this more clearly.