Bug 56868

Summary:

[chromium] Make WebClipboard::isFormatAvailable() be able to check for plain text

Product:

WebKit

Reporter:

Viet-Trung Luu <viettrungluu>

Component:

Platform

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dcheng, dimich, eric, tony

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
proposed patch	tony: review+, commit-queue: commit-queue-
take 2 (same patch, updated)	none

Viet-Trung Luu

Reported 2011-03-22 15:05:58 PDT

Basically, in WebKit, we just need to add an entry to the WebClipboard::Format enum. I have a patch....

Attachments
proposed patch (3.19 KB, patch) 2011-03-22 15:19 PDT, Viet-Trung Luu	tony: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
take 2 (same patch, updated) (3.21 KB, patch) 2011-03-23 10:02 PDT, Viet-Trung Luu	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Viet-Trung Luu

Comment 1 2011-03-22 15:19:25 PDT

Created attachment 86518 [details] proposed patch

Viet-Trung Luu

Comment 2 2011-03-22 15:28:38 PDT

Chromium-side CL containing corresponding changes in Chromium (and more): http://codereview.chromium.org/6724010/

Viet-Trung Luu

Comment 3 2011-03-22 16:11:25 PDT

Could I get a cq+ for this? Thanks in advance.

WebKit Commit Bot

Comment 4 2011-03-22 17:57:37 PDT

Comment on attachment 86518 [details] proposed patch Rejecting attachment 86518 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-7', 'land-a..." exit_code: 2 Last 500 characters of output: r81731 = f40b03778352d945ee70aef9aa78b6ae6c6958fd (refs/remotes/trunk) M Source/WebKit/mac/Plugins/WebBasePluginPackage.mm M Source/WebKit/mac/ChangeLog M Source/WebKit2/ChangeLog M Source/WebKit2/Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm M Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp r81732 = 5099c56863c375e4089a7ad0c8e41ab88e201bbc (refs/remotes/trunk) First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/trunk. Full output: http://queues.webkit.org/results/8228493

Viet-Trung Luu

Comment 5 2011-03-23 10:02:20 PDT

Created attachment 86636 [details] take 2 (same patch, updated)

Viet-Trung Luu

Comment 6 2011-03-23 10:03:03 PDT

Could we try again? (I thought the commit-queue was supposed to take care of ChangeLog conflicts?)

WebKit Commit Bot

Comment 7 2011-03-23 12:09:41 PDT

The commit-queue encountered the following flaky tests while processing attachment 86636 [details]: http/tests/websocket/tests/send.html bug 56945 (author: abarth@webkit.org) The commit-queue is continuing to process your patch.

WebKit Commit Bot

Comment 8 2011-03-23 12:13:29 PDT

Comment on attachment 86636 [details] take 2 (same patch, updated) Clearing flags on attachment: 86636 Committed r81792: <http://trac.webkit.org/changeset/81792>

WebKit Commit Bot

Comment 9 2011-03-23 12:36:39 PDT

The commit-queue encountered the following flaky tests while processing attachment 86636 [details]: media/invalid-media-url-crash.html bug 51138 (authors: inferno@chromium.org and jamesr@chromium.org) The commit-queue is continuing to process your patch.

Eric Seidel (no email)

Comment 10 2011-06-18 19:58:32 PDT

Looks like this was landed.

Note You need to log in before you can comment on or make changes to this bug.