Bug 56864

Summary:

Add the remaining steps to WebCore GYP build

Product:

WebKit

Reporter:

Adam Barth <abarth>

Component:

New Bugs

Assignee:

Adam Barth <abarth>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov, eric

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Bug Depends on:

Bug Blocks:

55018

Attachments:

Description	Flags
Patch	none

Description Adam Barth 2011-03-22 14:41:09 PDT

Add the remaining steps to WebCore GYP build

Comment 1 Adam Barth 2011-03-22 14:44:39 PDT

Created attachment 86510 [details]
Patch

Comment 2 Eric Seidel (no email) 2011-03-22 14:47:47 PDT

Comment on attachment 86510 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=86510&action=review

> Source/WebCore/gyp/copy-inspector-resources.sh:8
> +rm -f "${TARGET_BUILD_DIR}/${UNLOCALIZED_RESOURCES_FOLDER_PATH}/inspector/WebKit.qrc"

Seems ${TARGET_BUILD_DIR}/${UNLOCALIZED_RESOURCES_FOLDER_PATH}/inspector wants to be a local variable. :)

Comment 3 Adam Barth 2011-03-22 14:48:56 PDT

(In reply to comment #2)
> (From update of attachment 86510 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=86510&action=review
> 
> > Source/WebCore/gyp/copy-inspector-resources.sh:8
> > +rm -f "${TARGET_BUILD_DIR}/${UNLOCALIZED_RESOURCES_FOLDER_PATH}/inspector/WebKit.qrc"
> 
> Seems ${TARGET_BUILD_DIR}/${UNLOCALIZED_RESOURCES_FOLDER_PATH}/inspector wants to be a local variable. :)

True.  I didn't write this script.  (It's hard-coded into the xcodeproj.)

I suspect once we have this stuff "out in the open", there are lots of things we can improve.

Comment 4 Adam Barth 2011-03-22 14:52:14 PDT

Comment on attachment 86510 [details]
Patch

Clearing flags on attachment: 86510

Committed r81706: <http://trac.webkit.org/changeset/81706>

Comment 5 Adam Barth 2011-03-22 14:52:18 PDT

All reviewed patches have been landed.  Closing bug.