Bug 56860

Summary: WebCore GYP build should build without help from normal WebCore build
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 55018    
Attachments:
Description Flags
Patch
none
Patch none

Adam Barth
Reported 2011-03-22 13:38:51 PDT
WebCore GYP build should build without help from normal WebCore build
Attachments
Patch (6.18 KB, patch)
2011-03-22 13:42 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (6.16 KB, patch)
2011-03-22 13:50 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2011-03-22 13:42:16 PDT
Created attachment 86498 [details] Patch
Eric Seidel (no email)
Comment 2 2011-03-22 13:48:29 PDT
Comment on attachment 86498 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=86498&action=review OK. > Source/WebCore/ChangeLog:15 > + target, called "WebCore Support", which is less that aesthetically "less that"
Eric Seidel (no email)
Comment 3 2011-03-22 13:49:02 PDT
Comment on attachment 86498 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=86498&action=review > Source/WebCore/gyp/WebCore.gyp:282 > + 'mac_bundle': 1, This loks wrong.
Eric Seidel (no email)
Comment 4 2011-03-22 13:49:39 PDT
Comment on attachment 86498 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=86498&action=review > Source/WebCore/gyp/copy-forwarding-and-icu-headers.sh:4 > +rsync -aq --exclude ".svn" --exclude ".DS_Store" "$SRCROOT/../ForwardingHeaders" "$BUILT_PRODUCTS_DIR/$PRIVATE_HEADERS_FOLDER_PATH" > +rsync -aq --exclude ".svn" --exclude ".DS_Store" "$SRCROOT/../icu" "$BUILT_PRODUCTS_DIR/$PRIVATE_HEADERS_FOLDER_PATH" You might want to make the rsync command a variable if you add more of these...
Adam Barth
Comment 5 2011-03-22 13:50:32 PDT
Created attachment 86500 [details] Patch
Eric Seidel (no email)
Comment 6 2011-03-22 13:50:49 PDT
Comment on attachment 86498 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=86498&action=review > Source/WebCore/gyp/WebCore.gyp:150 > + 'inputs': [], > + 'outputs': [], Isn't [] the default here?
Adam Barth
Comment 7 2011-03-22 13:55:41 PDT
> Isn't [] the default here? Nope. The property is required. :(
Adam Barth
Comment 8 2011-03-22 14:07:32 PDT
Comment on attachment 86500 [details] Patch Clearing flags on attachment: 86500 Committed r81695: <http://trac.webkit.org/changeset/81695>
Adam Barth
Comment 9 2011-03-22 14:07:36 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.