|Summary:||GYP build should not have include paths that point within the source tree|
|Product:||WebKit||Reporter:||Adam Barth <abarth>|
|Component:||Tools / Tests||Assignee:||Nobody <webkit-unassigned>|
|Severity:||Normal||CC:||commit-queue, dglazkov, eric, mrowe|
|Version:||528+ (Nightly build)|
|OS:||OS X 10.5|
|Bug Depends on:|
Description Adam Barth 2011-03-21 17:29:59 PDT
Comment 2 Eric Seidel (no email) 2011-03-21 18:03:47 PDT
Comment on attachment 86398 [details] Patch What about for every non-mac port? it seems removing these is premature.
Comment 3 Adam Barth 2011-03-21 18:15:28 PDT
> What about for every non-mac port? it seems removing these is premature. I'd say that adding them is premature. :) We'll solve the non-mac port problem when we get there.
Comment 4 Eric Seidel (no email) 2011-03-21 18:18:09 PDT
Comment on attachment 86398 [details] Patch I guess. I'm pretty certain you'll want to revert this change the moment you try and build anywhere else, but your reasoning is fair.
Comment 5 WebKit Commit Bot 2011-03-21 22:40:08 PDT
Comment on attachment 86398 [details] Patch Clearing flags on attachment: 86398 Committed r81647: <http://trac.webkit.org/changeset/81647>
Comment 6 WebKit Commit Bot 2011-03-21 22:40:13 PDT
All reviewed patches have been landed. Closing bug.