Bug 56786

Summary: Production configuration in GYP isn't set up correctly
Product: WebKit Reporter: Adam Barth <abarth>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dglazkov, eric, mrowe
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 55018    
Attachments:
Description Flags
Patch
none
Patch none

Description Adam Barth 2011-03-21 17:27:24 PDT 
Sayth Mark:

[[
The generated JavaScriptCore.xcodeproj are not set up correctly (Production is no longer the default configuration, Production is based on DebugRelease.xcconfig rather than Base.xcconfig, etc.).
]]

It would be nice to know what else is in the "etc" part of the above list, but we should fix this problem before asking Mark to take another look.  I can also try to divine information from the existing project files.
Comment 1 Adam Barth 2011-03-21 19:17:50 PDT 
Created attachment 86408 [details]
Patch
Comment 2 Adam Barth 2011-03-21 23:12:15 PDT 
Comment on attachment 86408 [details]
Patch

This patch is wrong.  Please hold.
Comment 3 Adam Barth 2011-03-21 23:42:03 PDT 
Created attachment 86428 [details]
Patch
Comment 4 Eric Seidel (no email) 2011-03-22 00:48:51 PDT 
Comment on attachment 86428 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=86428&action=review

OK.

> Source/JavaScriptCore/ChangeLog:5
> +        Production configuration in GYP isn&apos;t set up correctly

Silly webkit-patch.
Comment 5 WebKit Commit Bot 2011-03-22 03:50:02 PDT 
Comment on attachment 86428 [details]
Patch

Clearing flags on attachment: 86428

Committed r81655: <http://trac.webkit.org/changeset/81655>
Comment 6 WebKit Commit Bot 2011-03-22 03:50:09 PDT 
All reviewed patches have been landed.  Closing bug.