Summary: | Solve the Assertions.cpp / -Wno-missing-format-attribute mystery | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||||
Component: | New Bugs | Assignee: | Adam Barth <abarth> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, dglazkov, eric, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Other | ||||||||
OS: | OS X 10.5 | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 55018 | ||||||||
Attachments: |
|
Description
Adam Barth
2011-03-21 16:38:21 PDT
Created attachment 86386 [details]
Patch
Comment on attachment 86386 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=86386&action=review > Source/JavaScriptCore/wtf/Assertions.cpp:29 > +#pragma GCC diagnostic ignored "-Wmissing-format-attribute" You should comment as to why this is needed for this file (so it has a prayer of being removed some day. Created attachment 86388 [details]
Patch
Comment on attachment 86388 [details]
Patch
Yay!
Comment on attachment 86388 [details] Patch Clearing flags on attachment: 86388 Committed r81624: <http://trac.webkit.org/changeset/81624> All reviewed patches have been landed. Closing bug. http://trac.webkit.org/changeset/81624 might have broken Qt Linux Release The following tests are not passing: css2.1/t09-c5526c-display-00-e.html |