Bug 56778

Summary: Add WebCoreExportFileGenerator to WebCore GYP build
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 55018    
Attachments:
Description Flags
Patch
none
Patch none

Adam Barth
Reported 2011-03-21 16:15:46 PDT
Add WebCoreExportFileGenerator to WebCore GYP build
Attachments
Patch (3.00 KB, patch)
2011-03-21 16:18 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (3.26 KB, patch)
2011-03-21 16:23 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2011-03-21 16:18:03 PDT
Created attachment 86382 [details] Patch
Dimitri Glazkov (Google)
Comment 2 2011-03-21 16:21:22 PDT
Comment on attachment 86382 [details] Patch ok.
Adam Barth
Comment 3 2011-03-21 16:23:05 PDT
Created attachment 86383 [details] Patch
Adam Barth
Comment 4 2011-03-21 16:23:43 PDT
Sorry, I was missing one dependency.
Eric Seidel (no email)
Comment 5 2011-03-21 16:45:02 PDT
Comment on attachment 86383 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=86383&action=review > Source/WebCore/ChangeLog:8 > + This target mirrors the eponymous target from WebCore.xcodeproj. I think you mean anonymous?
Adam Barth
Comment 6 2011-03-21 16:49:08 PDT
(In reply to comment #5) > (From update of attachment 86383 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=86383&action=review > > > Source/WebCore/ChangeLog:8 > > + This target mirrors the eponymous target from WebCore.xcodeproj. > > I think you mean anonymous? Turns out my usage is slightly incorrect unless you consider the targets to be the main characters and the build system to be a literary work: http://www.thefreedictionary.com/eponymous
Adam Barth
Comment 7 2011-03-21 16:49:38 PDT
Comment on attachment 86383 [details] Patch I think we can consider the build system a literary work. :)
Eric Seidel (no email)
Comment 8 2011-03-21 17:02:26 PDT
There are no people involved. Thus no eponyms... I think. Then again, I just learned the word "eponym". http://www.thefreedictionary.com/eponym
Adam Barth
Comment 9 2011-03-21 17:14:36 PDT
Comment on attachment 86383 [details] Patch Clearing flags on attachment: 86383 Committed r81623: <http://trac.webkit.org/changeset/81623>
Adam Barth
Comment 10 2011-03-21 17:14:40 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 11 2011-03-21 18:06:18 PDT
http://trac.webkit.org/changeset/81623 might have broken Qt Linux Release The following tests are not passing: css2.1/t09-c5526c-display-00-e.html
Note You need to log in before you can comment on or make changes to this bug.