Bug 56666 – Media Stream API: adding Stream and GeneratedStream classes.

• Component: DOM
• Status: RESOLVED FIXED

[Leandro Graciá Gil]

This patch introduces the Stream and GeneratedStream classes according to the lastest specification and integrating to the code introduced by previous patches.

[Leandro Graciá Gil]

Created attachment 86196 [details]
Patch

[Leandro Graciá Gil]

Created attachment 86200 [details]
Patch

[Leandro Graciá Gil]

No contents changed. Rebasing to solve problems with the bots.

[Leandro Graciá Gil]

Updating the bug platform settings (had the default ones).

[Leandro Graciá Gil]

Created attachment 93803 [details]
Patch

[Leandro Graciá Gil]

Created attachment 94243 [details]
Patch

Some minor fixes.

[Tony Gentilcore]

Comment on attachment 94243 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=94243&action=review

Just a couple of small questions. Everything else lgtm.

> Source/WebCore/dom/GeneratedStream.cpp:82
> +    if (m_readyState != ENDED)

Since stop() needs to be robust to ENDED streams, perhaps it would be easier to just call stop() unconditionally here at let it fail the first check?

> Source/WebCore/dom/Stream.cpp:57
> +    if (m_readyState == ENDED)

I might be missing it, but it doesn't seem like we'd ever want to call streamEnded while m_readyState == ENDED. If not, should we ASSERT here instead?

> Source/WebCore/dom/Stream.idl:36
> +                 attribute EventListener onreadystatechange;

onreadystatechange isn't in:
http://www.whatwg.org/specs/web-apps/current-work/#stream

Should we have it?

[Tommy Widenflycht]

Looks good to me, modulo Tony's comments.

View in context: https://bugs.webkit.org/attachment.cgi?id=94243&action=review

>> Source/WebCore/dom/Stream.idl:36
>> +                 attribute EventListener onreadystatechange;
> 
> onreadystatechange isn't in:
> http://www.whatwg.org/specs/web-apps/current-work/#stream
> 
> Should we have it?

Right, it used to be in the spec but must have been recently removed.

[Leandro Graciá Gil]

Created attachment 94448 [details]
Patch

[Leandro Graciá Gil]

Comment on attachment 94243 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=94243&action=review

>> Source/WebCore/dom/GeneratedStream.cpp:82
>> +    if (m_readyState != ENDED)
> 
> Since stop() needs to be robust to ENDED streams, perhaps it would be easier to just call stop() unconditionally here at let it fail the first check?

Fixed.

>> Source/WebCore/dom/Stream.cpp:57
>> +    if (m_readyState == ENDED)
> 
> I might be missing it, but it doesn't seem like we'd ever want to call streamEnded while m_readyState == ENDED. If not, should we ASSERT here instead?

Fixed.

>> Source/WebCore/dom/Stream.idl:36
>> +                 attribute EventListener onreadystatechange;
> 
> onreadystatechange isn't in:
> http://www.whatwg.org/specs/web-apps/current-work/#stream
> 
> Should we have it?

Fixed.

[WebKit Commit Bot]

Comment on attachment 94448 [details]
Patch

Rejecting attachment 94448 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-7', 'apply-..." exit_code: 2

Last 500 characters of output:
e/WebCore/page/MediaStreamController.h
patching file Source/WebCore/page/MediaStreamFrameController.cpp
patching file Source/WebCore/page/MediaStreamFrameController.h
patching file Source/WebCore/page/NavigatorUserMediaError.h
patching file Source/WebCore/page/NavigatorUserMediaSuccessCallback.h
patching file Source/WebCore/page/NavigatorUserMediaSuccessCallback.idl

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Tony Gentilcore', u'--..." exit_code: 1

Full output: http://queues.webkit.org/results/8734083

[Leandro Graciá Gil]

Created attachment 94598 [details]
Patch

Rebase only.

[WebKit Commit Bot]

Comment on attachment 94598 [details]
Patch

Clearing flags on attachment: 94598

Committed r87150: <http://trac.webkit.org/changeset/87150>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.