This patch introduces the StreamEvent class according to the lastest specification.
Created attachment 94987 [details] Patch
(In reply to comment #1) > Created an attachment (id=94987) [details] > Patch View in context: https://bugs.webkit.org/attachment.cgi?id=94987&action=review > Source/WebCore/ChangeLog:8 > + No new tests. (OOPS!) Same as mentioned in bug 61539 review. > Source/WebCore/dom/StreamEvent.h:42 > + static PassRefPtr<StreamEvent> create(const AtomicString& type, bool canBubble, bool cancelable, PassRefPtr<Stream>); Are you sure that canBubble and cancelable are required here? I'm not completely sure but it sounds to me like all stream events can't bubble and are not cancelable by definition. Take a look to dom/DeviceOrientationEvent.h/cpp for example.
(In reply to comment #2) > (In reply to comment #1) > > Created an attachment (id=94987) [details] [details] > > Patch > > View in context: https://bugs.webkit.org/attachment.cgi?id=94987&action=review > > > Source/WebCore/ChangeLog:8 > > + No new tests. (OOPS!) > > Same as mentioned in bug 61539 review. Done. > > Source/WebCore/dom/StreamEvent.h:42 > > + static PassRefPtr<StreamEvent> create(const AtomicString& type, bool canBubble, bool cancelable, PassRefPtr<Stream>); > > Are you sure that canBubble and cancelable are required here? I'm not completely sure but it sounds to me like all stream events can't bubble and are not cancelable by definition. Take a look to dom/DeviceOrientationEvent.h/cpp for example. Just following the IDL in the specification, even though I agree that it could be simplified.
Created attachment 95341 [details] Patch
Comment on attachment 95341 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=95341&action=review > Source/WebCore/dom/StreamEvent.idl:27 > + interface [ Might be nice to add a link to the spec here.
Created attachment 96404 [details] Patch
Comment on attachment 95341 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=95341&action=review >> Source/WebCore/dom/StreamEvent.idl:27 >> + interface [ > > Might be nice to add a link to the spec here. Done.
Rebased + fixed review comment.
Comment on attachment 96404 [details] Patch Clearing flags on attachment: 96404 Committed r88343: <http://trac.webkit.org/changeset/88343>
All reviewed patches have been landed. Closing bug.