Bug 61537 – Media Stream PeerConnection API: adding StreamEvent class

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Tommy Widenflycht]

This patch introduces the StreamEvent class according to the lastest specification.

[Tommy Widenflycht]

Created attachment 94987 [details]
Patch

[Leandro Graciá Gil]

(In reply to comment #1)
> Created an attachment (id=94987) [details]
> Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=94987&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests. (OOPS!)

Same as mentioned in bug 61539 review.

> Source/WebCore/dom/StreamEvent.h:42
> +    static PassRefPtr<StreamEvent> create(const AtomicString& type, bool canBubble, bool cancelable, PassRefPtr<Stream>);

Are you sure that canBubble and cancelable are required here? I'm not completely sure but it sounds to me like all stream events can't bubble and are not cancelable by definition. Take a look to dom/DeviceOrientationEvent.h/cpp for example.

[Tommy Widenflycht]

(In reply to comment #2)
> (In reply to comment #1)
> > Created an attachment (id=94987) [details] [details]
> > Patch
> 
> View in context: https://bugs.webkit.org/attachment.cgi?id=94987&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        No new tests. (OOPS!)
> 
> Same as mentioned in bug 61539 review.

Done.

> > Source/WebCore/dom/StreamEvent.h:42
> > +    static PassRefPtr<StreamEvent> create(const AtomicString& type, bool canBubble, bool cancelable, PassRefPtr<Stream>);
> 
> Are you sure that canBubble and cancelable are required here? I'm not completely sure but it sounds to me like all stream events can't bubble and are not cancelable by definition. Take a look to dom/DeviceOrientationEvent.h/cpp for example.

Just following the IDL in the specification, even though I agree that it could be simplified.

[Tommy Widenflycht]

Created attachment 95341 [details]
Patch

[Tony Gentilcore]

Comment on attachment 95341 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=95341&action=review

> Source/WebCore/dom/StreamEvent.idl:27
> +    interface [

Might be nice to add a link to the spec here.

[Tommy Widenflycht]

Created attachment 96404 [details]
Patch

[Tommy Widenflycht]

Comment on attachment 95341 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=95341&action=review

>> Source/WebCore/dom/StreamEvent.idl:27
>> +    interface [
> 
> Might be nice to add a link to the spec here.

Done.

[Tommy Widenflycht]

Rebased + fixed review comment.

[WebKit Review Bot]

Comment on attachment 96404 [details]
Patch

Clearing flags on attachment: 96404

Committed r88343: <http://trac.webkit.org/changeset/88343>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.