| Summary: | WebCore GYP build should build more derived sources | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||
| Component: | New Bugs | Assignee: | Adam Barth <abarth> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, dglazkov, eric | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Other | ||||||
| OS: | OS X 10.5 | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 55018 | ||||||
| Attachments: |
|
||||||
|
Description
Adam Barth
2011-03-16 19:54:00 PDT
Created attachment 86020 [details]
Patch
Comment on attachment 86020 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=86020&action=review > Source/WebCore/gyp/WebCore.gyp:92 > + ['exclude', 'JSMathMLElementWrapperFactory\\.(cpp|h)'], Should be keyed on mathml. Comment on attachment 86020 [details]
Patch
Yeah, I haven't sorted out the enable flags yet. That's something for after it links. :)
Comment on attachment 86020 [details] Patch Rejecting attachment 86020 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'apply-..." exit_code: 2 Last 500 characters of output: force']" exit_code: 1 Parsed 2 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/gyp/WebCore.gyp Hunk #1 FAILED at 52. Hunk #2 succeeded at 84 (offset 8 lines). Hunk #3 succeeded at 94 (offset 8 lines). 1 out of 3 hunks FAILED -- saving rejects to file Source/WebCore/gyp/WebCore.gyp.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Eric Seidel', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/8188558 Comment on attachment 86020 [details] Patch Clearing flags on attachment: 86020 Committed r81326: <http://trac.webkit.org/changeset/81326> All reviewed patches have been landed. Closing bug. |