Bug 56529 – WebCore GYP build should build more derived sources

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Adam Barth]

WebCore GYP build should build more derived sources

[Adam Barth]

Created attachment 86020 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 86020 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=86020&action=review

> Source/WebCore/gyp/WebCore.gyp:92
> +        ['exclude', 'JSMathMLElementWrapperFactory\\.(cpp|h)'],

Should be keyed on mathml.

[Adam Barth]

Comment on attachment 86020 [details]
Patch

Yeah, I haven't sorted out the enable flags yet.  That's something for after it links.  :)

[WebKit Commit Bot]

Comment on attachment 86020 [details]
Patch

Rejecting attachment 86020 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'apply-..." exit_code: 2

Last 500 characters of output:
force']" exit_code: 1

Parsed 2 diffs from patch file(s).
patching file Source/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/gyp/WebCore.gyp
Hunk #1 FAILED at 52.
Hunk #2 succeeded at 84 (offset 8 lines).
Hunk #3 succeeded at 94 (offset 8 lines).
1 out of 3 hunks FAILED -- saving rejects to file Source/WebCore/gyp/WebCore.gyp.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Eric Seidel', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/8188558

[Adam Barth]

Comment on attachment 86020 [details]
Patch

Clearing flags on attachment: 86020

Committed r81326: <http://trac.webkit.org/changeset/81326>

[Adam Barth]

All reviewed patches have been landed.  Closing bug.