Bug 56529 - WebCore GYP build should build more derived sources
Summary: WebCore GYP build should build more derived sources
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 55018
  Show dependency treegraph
 
Reported: 2011-03-16 19:54 PDT by Adam Barth
Modified: 2011-03-16 23:12 PDT (History)
3 users (show)

See Also:


Attachments
Patch (2.78 KB, patch)
2011-03-16 19:54 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2011-03-16 19:54:00 PDT
WebCore GYP build should build more derived sources
Comment 1 Adam Barth 2011-03-16 19:54:59 PDT
Created attachment 86020 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-03-16 22:22:08 PDT
Comment on attachment 86020 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=86020&action=review

> Source/WebCore/gyp/WebCore.gyp:92
> +        ['exclude', 'JSMathMLElementWrapperFactory\\.(cpp|h)'],

Should be keyed on mathml.
Comment 3 Adam Barth 2011-03-16 22:51:01 PDT
Comment on attachment 86020 [details]
Patch

Yeah, I haven't sorted out the enable flags yet.  That's something for after it links.  :)
Comment 4 WebKit Commit Bot 2011-03-16 22:57:04 PDT
Comment on attachment 86020 [details]
Patch

Rejecting attachment 86020 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'apply-..." exit_code: 2

Last 500 characters of output:
force']" exit_code: 1

Parsed 2 diffs from patch file(s).
patching file Source/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/gyp/WebCore.gyp
Hunk #1 FAILED at 52.
Hunk #2 succeeded at 84 (offset 8 lines).
Hunk #3 succeeded at 94 (offset 8 lines).
1 out of 3 hunks FAILED -- saving rejects to file Source/WebCore/gyp/WebCore.gyp.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Eric Seidel', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/8188558
Comment 5 Adam Barth 2011-03-16 23:12:30 PDT
Comment on attachment 86020 [details]
Patch

Clearing flags on attachment: 86020

Committed r81326: <http://trac.webkit.org/changeset/81326>
Comment 6 Adam Barth 2011-03-16 23:12:34 PDT
All reviewed patches have been landed.  Closing bug.