Bug 56410

Summary: EventHandler needs cleanup
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: HTML EditingAssignee: Nobody <webkit-unassigned>
Status: NEW ---    
Severity: Enhancement CC: ap, cmarcelo, dglazkov, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 58470, 59553, 59555, 59556, 58472, 58503, 59580, 59835, 59837, 60200, 60228    
Bug Blocks:    

Description Ryosuke Niwa 2011-03-15 13:44:12 PDT
EventHandler has many duplicated code and long functions.  This entire class needs to be refactored and cleaned up.
Comment 1 Sam Weinig 2011-03-20 12:00:04 PDT
If we are going to undertake cleaning up EventHandler, which is an extremely laudable goal and needs to be done, we should consider making some changes to its design as well. For instance, does it really need to be per-frame, or can we make it per Page?
Comment 2 Ryosuke Niwa 2011-03-22 12:44:20 PDT
(In reply to comment #1)
> If we are going to undertake cleaning up EventHandler, which is an extremely laudable goal and needs to be done, we should consider making some changes to its design as well. For instance, does it really need to be per-frame, or can we make it per Page?

It does store some states so we'll be changing the behavior if we're moving it to Page-level.  I guess we'll need to investigate per feature basis.  It might even be that we need two separate classes for Page-level and Frame-level states.
Comment 3 Dimitri Glazkov (Google) 2011-03-26 21:20:56 PDT
Some of the bits from EventHandler should be moved to EventDispatcher, which is being birthed in bug 57168.