Bug 56231

Summary: Introduce project_dir variable and make paths a whole lot saner. Ok, a little bit saner.
Product: WebKit Reporter: Dimitri Glazkov (Google) <dglazkov>
Component: New BugsAssignee: Dimitri Glazkov (Google) <dglazkov>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 55018    
Attachments:
Description Flags
Patch none

Dimitri Glazkov (Google)
Reported 2011-03-11 15:50:34 PST
Introduce project_dir variable and make paths a whole lot saner. Ok, a little bit saner.
Attachments
Patch (5.82 KB, patch)
2011-03-11 15:51 PST, Dimitri Glazkov (Google) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dimitri Glazkov (Google)
Comment 1 2011-03-11 15:51:45 PST
Created attachment 85549 [details] Patch
Eric Seidel (no email)
Comment 2 2011-03-11 16:33:28 PST
Comment on attachment 85549 [details] Patch Nice. Feel free to CC me on any other gyp changes.
WebKit Commit Bot
Comment 3 2011-03-11 17:06:00 PST
Comment on attachment 85549 [details] Patch Clearing flags on attachment: 85549 Committed r80906: <http://trac.webkit.org/changeset/80906>
WebKit Commit Bot
Comment 4 2011-03-11 17:06:05 PST
All reviewed patches have been landed. Closing bug.
Adam Barth
Comment 5 2011-03-11 18:53:16 PST
Comment on attachment 85549 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=85549&action=review > Source/JavaScriptCore/JavaScriptCore.gypi:3 > + 'project_dir': [ '<(DEPTH)/JavaScriptCore' ], You don't need to use DEPTH here. project_dir ends in _dir, which means it's treated as relative to the file its in. So... "." would have worked too.
Note You need to log in before you can comment on or make changes to this bug.