Bug 56217

Summary:

Start using derived sources correctly and link minidom with JavaScriptCore gyp project.

Product:

WebKit

Reporter:

Dimitri Glazkov (Google) <dglazkov>

Component:

New Bugs

Assignee:

Dimitri Glazkov (Google) <dglazkov>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Bug Depends on:

Bug Blocks:

55018

Attachments:

Description	Flags
Patch	abarth: review+

Description Dimitri Glazkov (Google) 2011-03-11 13:08:51 PST

Start using derived sources correctly and link minidom with JavaScriptCore gyp project.

Comment 1 Dimitri Glazkov (Google) 2011-03-11 13:10:22 PST

Created attachment 85517 [details]
Patch

Comment 2 Adam Barth 2011-03-11 13:28:05 PST

Comment on attachment 85517 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=85517&action=review

This restructures how the build works a bit, but probably in a good direction.

> Source/JavaScriptCore/gyp/generate-dtrace-header.sh:3
> +TRACING_D="${SRCROOT}/../runtime/Tracing.d";

The ... here makes me a bit sad, but it's probably ok.  Having these paths based on DEPTH is better.  Maybe we should pass the directory in like we're doing for the intermediate dir.

Comment 3 Dimitri Glazkov (Google) 2011-03-11 13:59:54 PST

Committed r80882: <http://trac.webkit.org/changeset/80882>