Bug 56197

Summary: JNIType is not specific to JNI so should be renamed
Product: WebKit Reporter: Steve Block <steveblock>
Component: New BugsAssignee: Steve Block <steveblock>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, andreip, commit-queue, eric, jorlow, steveblock, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 55383    
Attachments:
Description Flags
Patch
none
Patch commit-queue: commit-queue-

Description Steve Block 2011-03-11 08:55:11 PST 
JNIType is not specific to JNI so should be renamed
Comment 1 Steve Block 2011-03-11 08:58:01 PST 
This enum describes a general Java type, so should be renamed to JavaType and moved out of JNIUtility.h.

This is part of making JavaInstance a clean interface that is not dependent upon JNI. See Bug 55383.
Comment 2 Steve Block 2011-03-11 09:07:52 PST 
Created attachment 85479 [details]
Patch
Comment 3 Jeremy Orlow 2011-03-11 09:39:38 PST 
Comment on attachment 85479 [details]
Patch

r=me
Comment 4 Steve Block 2011-03-23 17:57:40 PDT 
Created attachment 86728 [details]
Patch
Comment 5 Steve Block 2011-03-23 17:58:21 PDT 
Comment on attachment 86728 [details]
Patch

Rebased only. Checking try-bots. No review required.
Comment 6 Steve Block 2011-03-24 02:49:26 PDT 
Comment on attachment 86728 [details]
Patch

Rebased only. Checking try-bots. No review required.
Comment 7 WebKit Commit Bot 2011-03-24 03:46:59 PDT 
Comment on attachment 86728 [details]
Patch

Rejecting attachment 86728 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'land-a..." exit_code: 1

Last 500 characters of output:
tTests/platform/gtk/fast/block/lineboxcontain/inline-box-vertical-expected.checksum
	A	LayoutTests/platform/gtk/fast/block/lineboxcontain/block-font-expected.txt
	A	LayoutTests/platform/gtk/fast/block/lineboxcontain/inline-replaced-expected.png
	A	LayoutTests/editing/selection/fake-drag-expected.txt
	M	LayoutTests/ChangeLog
r81858 = e75e7eb10efcc9c1b1b3dd52461ad2a4930057ee (refs/remotes/trunk)
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/trunk.

Full output: http://queues.webkit.org/results/8233466
Comment 8 Steve Block 2011-03-24 04:20:01 PDT 
Committed r81860: <http://trac.webkit.org/changeset/81860>
Comment 9 WebKit Review Bot 2011-03-24 07:19:31 PDT 
http://trac.webkit.org/changeset/81860 might have broken Windows XP Debug (Tests)
The following tests are not passing:
http/tests/inspector/network/network-redirect.html