Bug 55993

Summary: WebKit2: Plumb new full screen animation APIs through WebKit2.
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: WebKit Misc.Assignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, eric.carlson, sam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 56210, 56220, 56226    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch andersca: review+

Description Jer Noble 2011-03-08 21:37:46 PST 
The new Document animation APIs need to be plumbed through WebKit2 from the WebProcess to the UIProcess (and vice versa).
Comment 1 Jer Noble 2011-03-08 22:54:51 PST 
Created attachment 85134 [details]
Patch
Comment 2 Jer Noble 2011-03-09 01:12:11 PST 
Created attachment 85143 [details]
Patch
Comment 3 WebKit Review Bot 2011-03-09 01:53:48 PST 
Attachment 85134 [details] did not build on mac:
Build output: http://queues.webkit.org/results/8117256
Comment 4 WebKit Review Bot 2011-03-09 03:43:20 PST 
Attachment 85143 [details] did not build on mac:
Build output: http://queues.webkit.org/results/8118288
Comment 5 Jer Noble 2011-03-09 08:29:16 PST 
It looks like the mac builder didn't pick up the changes in 55992.
Comment 6 Jer Noble 2011-03-11 09:48:56 PST 
Since Bug #55992 was marked WONTFIX, updating this patch with stubbed out API.
Comment 7 Jer Noble 2011-03-11 10:42:37 PST 
Created attachment 85491 [details]
Patch
Comment 8 Jer Noble 2011-03-11 11:45:45 PST 
Created attachment 85504 [details]
Patch

Somehow, two braces became transposed.  This patch builds cleanly on amac.
Comment 9 Anders Carlsson 2011-03-11 16:55:48 PST 
Comment on attachment 85504 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=85504&action=review

> Source/WebKit2/WebProcess/FullScreen/WebFullScreenManager.cpp:69
> +    m_page->sendSync(Messages::WebFullScreenManagerProxy::SupportsFullScreen(), supports, 0, CoreIPC::Connection::NoTimeout);

No need to pass NoTimeout to sendSync, that's the default argument.
Comment 10 Jer Noble 2011-03-11 17:09:19 PST 
Comment on attachment 85504 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=85504&action=review

>> Source/WebKit2/WebProcess/FullScreen/WebFullScreenManager.cpp:69
>> +    m_page->sendSync(Messages::WebFullScreenManagerProxy::SupportsFullScreen(), supports, 0, CoreIPC::Connection::NoTimeout);
> 
> No need to pass NoTimeout to sendSync, that's the default argument.

Indeed, deleted.  (I think, in addition, that 0 is unnecessary.  We want m_page to put its own pageID for that value.)
Comment 11 Jer Noble 2011-03-11 21:38:28 PST 
Committed r80922: <http://trac.webkit.org/changeset/80922>