Bug 55967

Summary: NPAPI - jvalue conversion should not be in JavaInstance
Product: WebKit Reporter: Steve Block <steveblock>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: andreip, jorlow, steveblock
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Bug Depends on: 55966    
Bug Blocks: 55383, 55765    
Attachments:
Description Flags
Patch jorlow: review+

Steve Block
Reported 2011-03-08 14:20:29 PST
The logic to convert between NPAPI and jvalue values does not belong in JavaInstance, as this class logically represents a Java object and should not know about NPAPI types. Instead, this logic should be moved out of JavaInstance (and into JavaNPObject in the case of V8). This will also allow all implementors of the new JavaInstance interface to share this logic. See Bug 55383.
Attachments
Patch (5.97 KB, patch)
2011-03-09 03:47 PST, Steve Block 		jorlow: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Steve Block
Comment 1 2011-03-09 03:47:06 PST
Created attachment 85153 [details] Patch
Jeremy Orlow
Comment 2 2011-03-09 09:59:50 PST
Comment on attachment 85153 [details] Patch r=me
Andrei Popescu
Comment 3 2011-03-09 10:05:50 PST
LGTM
Steve Block
Comment 4 2011-03-09 10:17:53 PST
Committed r80647: <http://trac.webkit.org/changeset/80647>
Note You need to log in before you can comment on or make changes to this bug.