Bug 55936

Summary:

old-run-webkit-tests should ignore test files used by reftests

Product:

WebKit

Reporter:

Hayato Ito <hayato>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dpranke, hamaji, ojan

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Bug Depends on:

67936

Bug Blocks:

36065

Attachments:

Description	Flags
ignore-reftests	ojan: review+

Hayato Ito

Reported 2011-03-08 05:03:12 PST

Please see the master bug for the rationale: https://bugs.webkit.org/show_bug.cgi?id=36065 We are updating new-run-webkit-tests to support reftests. A old-run-webkit-tests should ignore test files used by reftests to avoid unexpected errors.

Attachments
ignore-reftests (1.93 KB, patch) 2011-03-08 19:23 PST, Hayato Ito	ojan: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Hayato Ito

Comment 1 2011-03-08 19:23:58 PST

Created attachment 85126 [details] ignore-reftests

Ojan Vafai

Comment 2 2011-03-08 23:07:42 PST

Comment on attachment 85126 [details] ignore-reftests View in context: https://bugs.webkit.org/attachment.cgi?id=85126&action=review Might want to wait until bug 55457 is r+'ed to make sure that none of the paths will change. > Tools/Scripts/old-run-webkit-tests:2460 > + extra line break

Hayato Ito

Comment 3 2011-03-09 03:33:35 PST

Hi Ojan, Thank you for the review. I'll fix the extra line break and land this after 55457 is r+'ed. (In reply to comment #2) > (From update of attachment 85126 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=85126&action=review > > Might want to wait until bug 55457 is r+'ed to make sure that none of the paths will change. > > > Tools/Scripts/old-run-webkit-tests:2460 > > + > > extra line break

Hayato Ito

Comment 4 2011-03-16 00:51:38 PDT

Committed r81225: <http://trac.webkit.org/changeset/81225>

Note You need to log in before you can comment on or make changes to this bug.