Bug 55802

Summary: Add skeletal WebCore.gyp
Product: WebKit Reporter: Dimitri Glazkov (Google) <dglazkov>
Component: New BugsAssignee: Dimitri Glazkov (Google) <dglazkov>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 55018    
Attachments:
Description Flags
Patch
none
Patch
none
Now added to configure script. abarth: review+, abarth: commit-queue-

Dimitri Glazkov (Google)
Reported 2011-03-04 16:12:56 PST
Add skeletal WebCore.gyp
Attachments
Patch (8.28 KB, patch)
2011-03-04 16:13 PST, Dimitri Glazkov (Google) 		no flags
DetailsFormatted DiffDiff
Patch (6.94 KB, patch)
2011-03-04 16:31 PST, Dimitri Glazkov (Google) 		no flags
DetailsFormatted DiffDiff
Now added to configure script. (7.75 KB, patch)
2011-03-04 16:46 PST, Dimitri Glazkov (Google) 		abarth: review+
abarth: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Dimitri Glazkov (Google)
Comment 1 2011-03-04 16:13:57 PST
Created attachment 84823 [details] Patch
Dimitri Glazkov (Google)
Comment 2 2011-03-04 16:31:51 PST
Created attachment 84825 [details] Patch
Dimitri Glazkov (Google)
Comment 3 2011-03-04 16:46:55 PST
Created attachment 84829 [details] Now added to configure script.
Adam Barth
Comment 4 2011-03-04 16:51:11 PST
Comment on attachment 84829 [details] Now added to configure script. View in context: https://bugs.webkit.org/attachment.cgi?id=84829&action=review > Source/WebCore/WebCore.gypi:11 > + 'bindings', > + 'bindings/generic', > + 'bindings/v8', > + 'bindings/v8/custom', > + 'bindings/v8/specialization', Presumably we'll need to add bindings/js at some point. > Source/WebCore/WebCore.gypi:54 > + 'platform/image-decoders/skia', There's some subtly here w.r.t. the various image libraries. > Source/gyp/configure:38 > + "WebCore" PEP-8 says this is missing a trailing comma.
Adam Barth
Comment 5 2011-03-04 16:56:18 PST
Committed r80393: <http://trac.webkit.org/changeset/80393>
Note You need to log in before you can comment on or make changes to this bug.