Bug 55712

Summary: JavaScriptCore GYP build should use a header map
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, dglazkov, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 55018    
Attachments:
Description Flags
Patch none

Description Adam Barth 2011-03-03 14:56:16 PST
JavaScriptCore GYP build should use a header map
Comment 1 Adam Barth 2011-03-03 14:57:51 PST
Created attachment 84634 [details]
Patch
Comment 2 Dimitri Glazkov (Google) 2011-03-03 14:59:18 PST
Comment on attachment 84634 [details]
Patch

k
Comment 3 Eric Seidel (no email) 2011-03-03 15:00:13 PST
Comment on attachment 84634 [details]
Patch

Really?  Are you sure you want this?  We'll need an explicit include list for other ports anyway...
Comment 4 WebKit Commit Bot 2011-03-03 21:16:23 PST
Comment on attachment 84634 [details]
Patch

Rejecting attachment 84634 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-7', 'apply-..." exit_code: 2

Last 500 characters of output:
).
1 out of 2 hunks FAILED -- saving rejects to file Source/JavaScriptCore/JavaScriptCore.gypi.rej
patching file Source/JavaScriptCore/gyp/JavaScriptCore.gyp
Hunk #1 succeeded at 110 (offset 3 lines).
Hunk #2 FAILED at 195.
Hunk #3 FAILED at 216.
Hunk #4 FAILED at 238.
3 out of 4 hunks FAILED -- saving rejects to file Source/JavaScriptCore/gyp/JavaScriptCore.gyp.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Dimitri Glazkov', u'--..." exit_code: 1

Full output: http://queues.webkit.org/results/8086447
Comment 5 Adam Barth 2011-03-04 11:21:40 PST
Comment on attachment 84634 [details]
Patch

Clearing flags on attachment: 84634

Committed r80368: <http://trac.webkit.org/changeset/80368>
Comment 6 Adam Barth 2011-03-04 11:21:44 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 WebKit Review Bot 2011-03-04 12:57:30 PST
http://trac.webkit.org/changeset/80368 might have broken GTK Linux 32-bit Release